bin/55274: npfctl(8) error handling could be improved

[tnn%nygren.pp.se@localhost]

>Number:         55274
>Category:       bin
>Synopsis:       npfctl(8) error handling could be improved
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 18 19:40:00 +0000 2020
>Originator:     Tobias Nygren
>Release:        6.99.63
>Organization:
>Environment:
>Description:
1) Using a variable with 0 netmask causes assertion failure:

$za_warudo = 0.0.0.0/0
group default {
  pass final from $za_warudo to $za_warudo
}

Expected result:
Syntactically valid config should either load or instruct user to use the "any" keyword.
Actual result:
assertion "nvl->nvl_error == 0" failed: file "/work/src/sys/external/bsd/libnv/dist/nvlist.c", line 363, function "nvlist_find"

2) If one habitually encloses a variable in curly braces (like in sh(1) or make(1), it causes assertion failure:

$foo = 10.0.0.1/32
group default {
  pass final all
  pass final from $foo to ${foo}
}

Expected result:
Parser error indicating line number and type of problem.
Actual result:
assertion "false" failed: file "/work/src/usr.sbin/npf/npfctl/npf_build.c", line 323, function "npfctl_build_vars"

>How-To-Repeat:

>Fix: