PR/55102 CVS commit: src

["Christos Zoulas" <christos%netbsd.org@localhost>]

The following reply was made to PR kern/55102; it has been noted by GNATS.

From: "Christos Zoulas" <christos%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/55102 CVS commit: src
Date: Fri, 15 May 2020 19:32:29 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri May 15 23:32:28 UTC 2020
 
 Modified Files:
 	src/distrib/sets/lists/base: shl.mi
 	src/distrib/sets/lists/comp: mi shl.mi
 	src/distrib/sets/lists/debug: mi shl.mi
 	src/sys/rump/fs: Makefile.rumpfscomp
 	src/sys/rump/librump/rumpvfs: rumpfs.c
 	src/tests: Makefile.inc
 	src/tests/fs/ffs: Makefile
 	src/tests/fs/puffs: Makefile
 
 Log Message:
 PR/55102: Kamil Rytarowski: Duplicate fifo_vnodeop_entries,
 fifo_vnodeop_opv_desc symbols.
 
 Many filesystems ffs, lfs, ulfs, chfs, ext2fs etc. use fifofs
 internally for their fifo vnops. NFS does too, but it also needs
 networking anyway.  Unfortunately fifofs brings in a lot of the
 networking code so that the rumpkernel is not well partition. In
 addition the fifo code is rarely used.
 
 The existing hack depended on duplicating the above symbols and
 adding minimal functionality for the majority of the the tests
 (except the ffs and the puffs one). In these two cases both symbols
 were loaded and the symbol sizes clashed which broke the sanitizers.
 While this can be fixed with weak symbols and other kinds of
 indirection, it is more straight forward to select between the
 minimal and the full fifofs implementation by introducing a new
 shared library librumpvfs_nofifofs.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.885 -r1.886 src/distrib/sets/lists/base/shl.mi
 cvs rdiff -u -r1.2325 -r1.2326 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.331 -r1.332 src/distrib/sets/lists/comp/shl.mi
 cvs rdiff -u -r1.309 -r1.310 src/distrib/sets/lists/debug/mi
 cvs rdiff -u -r1.246 -r1.247 src/distrib/sets/lists/debug/shl.mi
 cvs rdiff -u -r1.7 -r1.8 src/sys/rump/fs/Makefile.rumpfscomp
 cvs rdiff -u -r1.160 -r1.161 src/sys/rump/librump/rumpvfs/rumpfs.c
 cvs rdiff -u -r1.6 -r1.7 src/tests/Makefile.inc
 cvs rdiff -u -r1.21 -r1.22 src/tests/fs/ffs/Makefile
 cvs rdiff -u -r1.15 -r1.16 src/tests/fs/puffs/Makefile
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.