NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

install/55202: sysinst doesn't release temprary swap in some error cases?



>Number:         55202
>Category:       install
>Synopsis:       sysinst doesn't release temprary swap in some error cases?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 23 17:55:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0
>Organization:
>Environment:
System: NetBSD 9.0 (RAMDISK) #0: Fri Feb 14 00:06:28 UTC 2020  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/hp300/compile/RAMDISK
Architecture: m68k
Machine: hp300
>Description:
When checking PR install/55201 (9.0 hp300 sysinst cannot find root)
I noticed that sysinst add a swap using the target /dev/sd0b disk
but it was not released after error.
Then the second try of upgrade silently fails.


---
[same procedure of PR install/55201]

---                                                                                
 No root partition defined.  Cannot continue 
 


                             
                             
                             
                             
                             
                           
                           >Hit enter to continue 
                           

---
                                                                                
 NetBSD/hp300 9.0

 This menu-driven tool is designed to help you install NetBSD to a hard disk,
 or upgrade an existing NetBSD system, with a minimum of work.
 In the following menus type the reference letter (a, b, c, ...) to select an
 item, or type CTRL+N/CTRL+P to select the next/previous item.
 The arrow keys and Page-up/Page-down may also work.
 Activate the current selection from the menu by typing the enter key.
 If your machine has 4MB or less, sysinst will not operate correctly.
 
 Thank you for using NetBSD!
               
                NetBSD-9.0 Install System                     
                                                              
                a: Install NetBSD to hard disk                
               >b: Upgrade NetBSD on a hard disk                              
                c: Re-install sets or install additional sets                 
                d: Reboot the computer                                        
                e: Utility menu                                               
                f: Config menu                                                
                x: Exit Install System                                        
                               

---
                                                                                
 Ok, let's upgrade NetBSD on your hard disk.  As always, this will change
 information on your hard disk.  You should have made a full backup before
 this procedure!  Do you really want to upgrade NetBSD?  (This is your last  
 warning before this procedure starts modifying your disks.)  
 
 
 
 
 
                               
                                Yes or no?    
                                              
                                a: No         
                               >b: Yes        
                               

---
                                                                                
 On which disk do you want to upgrade NetBSD?


                             
                              Available disks                                 
                                                                              
                              a: current system                               
                             >b: sd0 (2.2G)                                   
                              x: Exit                                         
                             

---

When I chose "b" on this "On which disk" prompt, sysinst silently got
the initial sysinst menu:
---

 NetBSD/hp300 9.0 

 This menu-driven tool is designed to help you install NetBSD to a hard disk,
 or upgrade an existing NetBSD system, with a minimum of work.

 :
---

When I select "a: Install NetBSD to hard disk" in the initial menu,
sysinst warns swap in the selected disk is in use:

---
[..]

 Thank you for using NetBSD!
               
                NetBSD-9.0 Install System                     
                                                              
               >a: Install NetBSD to hard disk                
                b: Upgrade NetBSD on a hard disk              
                c: Re-install sets or install additional sets 
                d: Reboot the computer                        
                e: Utility menu                               
                f: Config menu                                
                x: Exit Install System                        
               

---
                                                                                
 You have chosen to install NetBSD on your hard disk.  This will change
 information on your hard disk.  You should have made a full backup before
 this procedure!  This procedure will do the following things:
                 a) Partition your disk
                 b) Create new BSD file systems
                 c) Load and install distribution sets
                 d) Some initial system configuration                           
 
 (After you enter the partition information but before your disk is changed,
 you will have the opportunity to quit this procedure.)
 
 Shall we continue?
                               
                                Yes or no?    
                                              
                                a: No         
                               >b: Yes        
                               

---
                                                                               
 On which disk do you want to install NetBSD?


                          
                           Available disks          
                                                    
                          >a: sd0 (2.2G)            
                           b: Extended partitioning                           
                           x: Exit                  
                          

---

 The disk that you selected has a swap partition that may currently be in use
 if your system is low on memory.  Because you are going to repartition this
 disk, this swap partition will be disabled now.  Please beware that this
 might lead to out of swap errors.  Should you get such an error, please
 restart the system and try again.




                           
                           >Hit enter to continue 
                           

---

Actually /dev/sd0b is in swapctl:
---
[1] + Suspended               sysinst
# swapctl -l
Device      1K-blocks     Used    Avail Capacity  Priority
/dev/sd0b      131200        0   131200     0%    0
# 
---

Maybe that's the reason silent failure on the second try?

>How-To-Repeat:
See above.

>Fix:
Maybe it's better to call "swapctl -d" on any errors during installation?
(at least silent failure is a bad thing)

---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index