NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: kern/55166: uvm_pdpolicy_clock params (anon/exec/file max/min)defaults



>  >  > Replace these immediate default values with proper macro
>  >  > as existing CLOCK_INACTIVEPCT:
>  >  
>  >  If these macros are going to be visible outside of uvm_pdpolicy_clock.c,
>  >  they need to have a prefix on them, e.g. PDPOLICY_CLOCK_INACTIVEPCT.
>  
>  Are you suggesting existing CLOCK_INACTIVEPCT should also be changed?
>  (maybe it's okay because it is not mentioned in options(4) though)
>  
>  Note these parameters are also in sysctl(9) but without "pdpolicy_clock":
>  ---
>  % sysctl vm
>   :
>  vm.anonmin = 10
>  vm.filemin = 5
>  vm.execmin = 30
>  vm.anonmax = 60
>  vm.filemax = 20
>  vm.execmax = 50
>  vm.inactivepct = 33

yes - these values are initialised by clock as well as clockpro.

i think i general PDPOLICY_<value> seems better for now, with
out the CLOCK in the name, but with PDPOLICY in the name.


.mrg.


Home | Main Index | Thread Index | Old Index