PR/54897 CVS commit: src/sys/rump/net/lib/libshmif

["Ryota Ozaki" <ozaki-r%netbsd.org@localhost>]

The following reply was made to PR kern/54897; it has been noted by GNATS.

From: "Ryota Ozaki" <ozaki-r%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54897 CVS commit: src/sys/rump/net/lib/libshmif
Date: Tue, 25 Feb 2020 03:24:48 +0000

 Module Name:	src
 Committed By:	ozaki-r
 Date:		Tue Feb 25 03:24:48 UTC 2020
 
 Modified Files:
 	src/sys/rump/net/lib/libshmif: if_shmem.c
 
 Log Message:
 shmif: use cprng_strong64 instead of cprng_fast64 to generate a unique ID
 
 shmif uses random bytes generated by cprng(9) as a unique device ID
 between rump kernels to identify packets fed by itself and not receive
 them.  So if generated bytes are identical between shmif interfaces on
 different rump kernels, shmif may drop incoming packets unintentionally.
 This is one cause of recent ATF test failures of IPsec.
 
 Fix it by using cprng_strong64 instead of cprng_fast64.  This is a
 workaround and we should also investigate why cprng_fast64 starts
 failing on rump kernels, although using cprng_strong64 in initialization
 itself is feasible.
 
 Fix PR kern/54897
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.78 -r1.79 src/sys/rump/net/lib/libshmif/if_shmem.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.