NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/54963 CVS commit: src/sys
The following reply was made to PR kern/54963; it has been noted by GNATS.
From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/54963 CVS commit: src/sys
Date: Sat, 15 Feb 2020 01:21:57 +0000
Module Name: src
Committed By: riastradh
Date: Sat Feb 15 01:21:56 UTC 2020
Modified Files:
src/sys/arch/mips/adm5120/dev: ahci.c
src/sys/dev/ic: sl811hs.c
src/sys/dev/usb: ehci.c motg.c ohci.c uhci.c vhci.c xhci.c
src/sys/external/bsd/dwc2: dwc2.c
Log Message:
Fix mistakes in previous sloppy change with root intr xfers.
- Make sure ux_status is set to USBD_IN_PROGRESS when started.
Otherwise, if it is still in flight when we abort the pipe,
usbd_ar_pipe will skip calling upm_abort.
- Initialize ux_status under the lock; in principle a completion
interrupt (or a delay) could race with the initialization.
- KASSERT that the xfer is in progress when we're about to complete
it.
Candidate fix for PR kern/54963 for other HCI drivers than uhci.
ok nick
ok phone
(This is the change that nick evidently MEANT to ok when he ok'd the
previous one!)
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/arch/mips/adm5120/dev/ahci.c
cvs rdiff -u -r1.102 -r1.103 src/sys/dev/ic/sl811hs.c
cvs rdiff -u -r1.272 -r1.273 src/sys/dev/usb/ehci.c
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/usb/motg.c
cvs rdiff -u -r1.294 -r1.295 src/sys/dev/usb/ohci.c
cvs rdiff -u -r1.292 -r1.293 src/sys/dev/usb/uhci.c
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/vhci.c
cvs rdiff -u -r1.117 -r1.118 src/sys/dev/usb/xhci.c
cvs rdiff -u -r1.68 -r1.69 src/sys/external/bsd/dwc2/dwc2.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index