install/54921: sysinst partition editor fails on x68k/9.0_RC2

[isaki%pastel-flower.jp@localhost]

>Number:         54921
>Category:       install
>Synopsis:       sysinst partition editor fails on x68k/9.0_RC2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 02 16:38:23 +0000 2020
>Originator:     Tetsuya Isaki
>Release:        NetBSD-9.0_RC2
>Organization:
>Environment:
NetBSD 9.0_RC2 x68k
>Description:
sysinst partition editor fails on x68k/9.0_RC2, and it has two problems.

1. x68k's partition editor displayed incomplete error message:

   | The order of partition  is wrong.  Edit again?

  It should be %s ?
  (arch/mvme68k/msg.md.en has the same?)

----------
RCS file: /cvsroot/src/usr.sbin/sysinst/arch/x68k/msg.md.en,v
retrieving revision 1.1
diff -u -r1.1 msg.md.en
--- arch/x68k/msg.md.en	26 Jul 2014 19:30:47 -0000	1.1
+++ arch/x68k/msg.md.en	2 Feb 2020 10:00:31 -0000
@@ -56,7 +56,7 @@
 }
 
 message ordering
-{The order of partition %c is wrong.  Edit again?}
+{The order of partition %s is wrong.  Edit again?}
 
 message emptypart
 {There is an valid partition %c after empty partition(s).
----------


2. The partition editor always displayed above error message.
  In arch/x68k/md.c:md_check_partitions(), install->infos seems be
  bsd disklabel.  If it's true, it should skip RAW_PART (sdNc) ?

----------
RCS file: /cvsroot/src/usr.sbin/sysinst/arch/x68k/md.c,v
retrieving revision 1.8.2.1
diff -u -r1.8.2.1 md.c
--- arch/x68k/md.c	17 Dec 2019 09:44:50 -0000	1.8.2.1
+++ arch/x68k/md.c	2 Feb 2020 10:00:31 -0000
@@ -163,6 +163,8 @@
 	char desc[STRSIZE];
 
 	for (i = 0; i < install->num; i++) {
+		if (i == RAW_PART)
+			continue;
 		if (i > 0) {
 			if (install->infos[i].cur_start < last_end) {
 				snprintf(desc, sizeof desc,
----------


With this two patches, I was able to complete the installation.

>How-To-Repeat:
Before installation, I prepared three Human68k partitions on the disk.
 1 non Human68k (for bsd ffs)
 2 non Human68k (for bsd swap)
 3 Human68k

Boot from sysinst floppies.
Choose "a: Install NetBSD to hard disk"
Choose "b: Yes"
Choose "a: sd0 (512M)"
Choose "a: Use existing disklabel partitions"

Choose "a:" and set newfs=yes, mount=yes, mountpoint=/.  I left all
other parameters(values) in the table untouched.
 |  a:     64   819263  819200       FFS NI  /
 |  b: 819264   884799   65536      swap
 |  c:      0  1048575 1048576  Whole disk
 |  d: 884800  1046591  161792     MSDOS

Here I choose "x: Partition sizes ok", then the message will be displayed.

 | The order of partition  is wrong.  Edit again?

>Fix:
See above.