install/54836: Wrong install binary set suffix in INSTALL notes

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         54836
>Category:       install
>Synopsis:       Wrong install binary set suffix in INSTALL notes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 05 18:15:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1
>Organization:
>Environment:
System: NetBSD 9.0_RC1
Architecture: all
Machine: all but except amd64, sparc64, and alpha
>Description:
https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0_RC1/i386/INSTALL.html
https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0_RC1/sun3/INSTALL.html
etc. use ".tar.xz" for set names:
> You will at a minimum need one of the kernel sets, typically kern-GENERIC.tar.xz, as well as base.tar.xz and etc.tar.xz. In a typical workstation installation you will probably want all the installation sets. 
 :
>  The i386 binary distribution sets are distributed as gzipped tar files named with the extension .tar.xz, e.g. base.tar.xz. 

>  The sun3 binary distribution sets are distributed as gzipped tar files named with the extension .tar.xz, e.g. base.tar.xz. 

but they use .tgz for set names.

>How-To-Repeat:
See above.

>Fix:
Wrong .if condition in src/distrib/notes/Makefile.inc? (untested)

Index: Makefile.inc
===================================================================
RCS file: /cvsroot/src/distrib/notes/Makefile.inc,v
retrieving revision 1.52
diff -u -p -d -r1.52 Makefile.inc
--- Makefile.inc	30 Nov 2019 00:28:27 -0000	1.52
+++ Makefile.inc	5 Jan 2020 18:06:47 -0000
@@ -29,7 +29,7 @@ whatis: .OPTIONAL
 
 PRESET=	${GFLAGS} -U -dM=${M} -dV=${DISTRIBVER} -d.CURDIR=${.CURDIR} -r${M}=1
 PRESET+=	-rmajor=${DISTRIBVER:C/\..*$//}
-.if ${USE_XZ_SETS}
+.if ${USE_XZ_SETS} == "yes"
 PRESET+=	-dsetsuffix=tar.xz
 .else
 PRESET+=	-dsetsuffix=tgz


Definition in src/share/mk/bsd.own.mk:
---
# Default to USE_XZ_SETS on some 64bit architectures where decompressor
# memory will likely not be in short supply.
# Since pigz can not create .xz format files currently, disable .xz
# format if USE_PIGZGZIP is enabled.
.if ${USE_PIGZGZIP} == "no" && \
		(${MACHINE} == "amd64" || \
		 ${MACHINE} == "sparc64" || \
		 ${MACHINE} == "alpha")
USE_XZ_SETS?= yes
.else
USE_XZ_SETS?= no
.endif 
---