install/54833: miniroot install fails to configure network

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         54833
>Category:       install
>Synopsis:       miniroot install fails to configure network
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 05 14:30:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1
>Organization:
>Environment:
System: NetBSD mirage 9.0_RC1 NetBSD 9.0_RC1 (GENERIC) #11: Thu Jan 2 14:19:17 JST 2020 tsutsui@mirage:/s/netbsd-9/src/sys/arch/i386/compile/GENERIC i386
Architecture: m68k
Machine: sun3, but affects all miniroot ports
>Description:
The miniroot install script for NetBSD/sun3 9.0_RC1 fails
to configure network:

---
You may configure the following network interfaces (the interfaces
marked with [X] have been successfully configured):

    le0

Configure which interface? [done] le0
IP address? [] 192.168.20.65
Symbolic (host) name? hydra
Your network interface might require explicit selection
of the type of network medium attached. Supported media:
manual
Additional media type arguments (none)? [] 
Your network interface might require additional link-layer
directives (like 'link0'). If this is the case you can enter
these at the next prompt.

Additional link-layer arguments (none)? [] 
usage: ifconfig [-h] [-m] [-v] [-z] interface
        [ af [ address [ dest_addr ] ] [ netmask mask ] [ prefixlen n ]
                [ alias | -alias ] ]
        [ up ] [ down ] [ metric n ] [ mtu n ]
        [ vlan n vlanif i ] [ -vlanif i ]
        [ [ af ] tunnel src_addr dest_addr ] [ deletetunnel ]
        [ media type ] [ mediaopt opts ] [ -mediaopt opts ] [ instance minst ]
        [ nwid network_id ] [ nwkey network_key | -nwkey ]
        [ list scan ]
        [ powersave | -powersave ] [ powersavesleep duration ]
        [ hidessid | -hidessid ] [ apbridge | -apbridge ]
        [ arp | -arp ]
        [ preference n ]
        [ link0 | -link0 ] [ link1 | -link1 ] [ link2 | -link2 ]
        [ linkstr str | -linkstr ]
        [ description str | descr str | -description | -descr ]
       ifconfig -a [-b] [-d] [-h] [-m] [-u] [-v] [-z] [ af ]
       ifconfig -l [-b] [-d] [-s] [-u]
       ifconfig -C
       ifconfig -w n
       ifconfig interface create
       ifconfig interface destroy

You may configure the following network interfaces (the interfaces
marked with [X] have been successfully configured):

    le0

Configure which interface? [done]
---

>How-To-Repeat:
Install NetBSD/sun3 9.0_RC1 via miniroot.fs and configure network.

>Fix:
In src/distrib/miniroot/install.sub rev 1.47, netmask line was changed:
 https://nxr.netbsd.org/diff/src/distrib/miniroot/install.sub?r1=/src/distrib/miniroot/install.sub@1.46&r2=/src/distrib/miniroot/install.sub@1.47&format=u&full=0
---
410
411	_interface_ip=$1
412	_interface_mask=$2
413
414	# Get IP address
415	resp=""		# force one iteration
416 -	while [ "X${resp}" = X"" ]; do
416 +	while [ -z "${resp}" ]; do
417		echo -n "IP address? [$_interface_ip] "
418		getresp "$_interface_ip"
419		_interface_ip=$resp
420	done
421
422	# Get symbolic name
423	resp=""		# force one iteration
424 -	while [ "X${resp}" = X"" ]; do
424 +	while [ -z "${resp}" ]; do
425		echo -n "Symbolic (host) name? "
426		getresp ""
427		_interface_symname=$resp
428	done
429
430	# Get netmask
431	resp=""		# force one iteration
432 -	while [ "X${resp}" = X"" ]; do
432 +	while [ -n "${resp}" ]; do
433		echo -n "Netmask? [$_interface_mask] "
434		getresp "$_interface_mask"
435		_interface_mask=$resp
436	done
---

For line 432 it should be "-z" instead of "-n" as other lines?

---
Izumi Tsutsui