Re: lib/54510 (libedit: filename completion broken in quote/double quaote)

[Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>]

The following reply was made to PR lib/54510; it has been noted by GNATS.

From: Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>
To: Tom Lane <tgl%sss.pgh.pa.us@localhost>
Cc: NetBSD GNATS <gnats-bugs%netbsd.org@localhost>, Abhinav Upadhyay <abhinav%netbsd.org@localhost>, 
	Rin Okuyama <rokuyama.rk%gmail.com@localhost>
Subject: Re: lib/54510 (libedit: filename completion broken in quote/double quaote)
Date: Sun, 5 Jan 2020 13:00:04 +0530

 On Sun, Jan 5, 2020 at 12:36 AM Tom Lane <tgl%sss.pgh.pa.us@localhost> wrote:
 >
 > Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost> writes:
 > > On Sat, Jan 4, 2020 at 6:41 AM Tom Lane <tgl%sss.pgh.pa.us@localhost> wrote:
 > >> Given the precedent of other nearby behaviors, maybe the right
 > >> fix is to skip the unescaping when attempted_completion_function
 > >> is non-NULL.  I haven't tried to code that though.
 >
 > > Can you verify if this patch fixes the problem?
 >
 > I think you have the check backwards: this
 > +       if (!do_unescape) {
 > should be
 > +       if (do_unescape) {
 >
 > With that correction, it seems to work for me.
 >
 
 Thanks for the correction and verifying. I committed the change.