Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR bin/54741; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.
Date: Sat, 28 Dec 2019 10:57:44 -0500

 --Apple-Mail=_7FE92561-7B5C-4B25-AF09-D78C9F04F625
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 Go for it, but please add a the explanation below as a commit message or =
 a comment.
 
 Best,
 
 christos
 
 > On Dec 27, 2019, at 9:45 PM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> =
 wrote:
 >=20
 > The following reply was made to PR bin/54741; it has been noted by =
 GNATS.
 >=20
 > From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
 > To: christos%zoulas.com@localhost
 > Cc: gnats-bugs%netbsd.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
 > Subject: Re: bin/54741: postinstall(8) fix no longer update =
 /etc/rc.subr etc.
 > Date: Sat, 28 Dec 2019 11:41:17 +0900
 >=20
 >> Is it okay to commit "rc* files in /etc/" part (for this PR) first?
 >=20
 > I'll commit this if there is no further comment.
 >=20
 >> i.e. there is no info in src/distrib or /etc/mtree to check
 >> "which rc files can be overwritten unconditionally on upgrade"
 >> so postinstall(8) should have the list.
 >>=20
 >> Index: postinstall.in
 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 >> RCS file: /cvsroot/src/usr.sbin/postinstall/postinstall.in,v
 >> retrieving revision 1.5.2.2
 >> diff -u -p -d -r1.5.2.2 postinstall.in
 >> --- postinstall.in	10 Nov 2019 12:58:30 -0000	1.5.2.2
 >> +++ postinstall.in	22 Dec 2019 01:20:41 -0000
 >> @@ -1415,6 +1415,12 @@ do_pwd_mkdb()
 >> #	rc
 >> #
 >>=20
 >> +rc_644_files=3D"
 >> +rc
 >> +rc.subr
 >> +rc.shutdown
 >> +"
 >> +
 >> rc_obsolete_vars=3D"
 >> amd amd_master
 >> btcontrol btcontrol_devices
 >> @@ -1494,8 +1511,8 @@ do_rc()
 >> 	local rc_external_files=3D"blacklist nsd unbound"
 >>=20
 >> 	# rc* files in /etc/
 >> -	local rc_444_files=3D"$(select_set_files /etc/rc \
 >> -	    "/etc/\(rc[^[:space:]/]*\)" ${etcsets})"
 >> +	#local rc_644_files=3D"$(select_set_files /etc/rc \
 >> +	#    "/etc/\(rc[^[:space:]/]*\)" ${etcsets})"
 >>=20
 >> 	# no-obsolete rc files in /etc/rc.d
 >> 	local rc_555_files=3D"$(select_set_files /etc/rc.d/ \
 >>=20
 >=20
 > ---
 > Izumi Tsutsui
 >=20
 
 
 --Apple-Mail=_7FE92561-7B5C-4B25-AF09-D78C9F04F625
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCXgd7eAAKCRBxESqxbLM7
 Or8TAKC1+K6/49xPlaCfRj9wx9P9bYZuLQCgu3AdFDQPkifrGicLouw1gwRBPp8=
 =xpIu
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_7FE92561-7B5C-4B25-AF09-D78C9F04F625--