Re: kern/54790: 9.0_RC1 kernel crash in ata_recovery_resume() (in NCQ support?)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR kern/54790; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: jaromir.dolecek%gmail.com@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/54790: 9.0_RC1 kernel crash in ata_recovery_resume() (in NCQ
	 support?)
Date: Sat, 28 Dec 2019 21:28:11 +0900

 >  Can you try kernel with DEBUG+DIAGNOSTIC?
 >  
 >  There is KASSERTMSG() which should trigger if the xfer is no longer active
 >  - after ata_queue_active() returns the slot as active, it should never
 >  actually happen the ata_queue_hwslot_to_xfer() returns NULL.
 
 KASSERT log from NetBSD/i386 9.0_RC1 GENERIC + options DIAGNOSTIC
 + options DEBUG + options LOCKDEBUG:
 
  https://gist.github.com/tsutsui/9e4fd770c6207c2af64ffb3c65c29b24
 
 Typed manually from the above one (for future search):
 ---
 panic: kernel diagnostic assertion "(chq->active_xfers_used & __BIT(xfer->c_slot)) != 0" failed: file "../../../../dev/ata/ata.c", line 1332
 cpu0: Begin traceback...
 vpanic(c10beea0,dc723eec,dc723f0c,c0189467,c10beea0,c10bee07,c10d4440,c10d3d81,534,20) at netbsd:vpanic+0x12d
 kern_assert(c10beea0,c10bee07,c10d4440,c10d3d81,534,20,c555a4d0,c5396b88,c5396000,dc723f3c) at netbsd:kern_asset+0x23
 ata_deactivate_xfer(c5396b88,c555a4d0,ba0,20,a,0,6b88,c555a4d0,c555ae30,2) at netbsd:ata_deactivate_xfer+0x5f
 ahci_bio_complete(c5396b88,c555a4d0,0,c5396b98,c14cee00,c018c03d,dc723f94,c0963cce,c5396b88,c4d78860) at netbsd:ahci_bio_complete+0x137
 ata_timeout(c5396b88,c4d78860,dc71320c,c4d5a040,c0937f18,c14cee04,c5396b88,0,c14cee60,dc713074) at netbsd:ata_timeout+0x66
 callout_softclock(0,dc713074,c0100400,16a7000,16b0010,30,c0100010,10,0,13b4c0) at netbsd:callout_softclock+0x37e
 softint_dispatch(c4d78020,2,0,0,0,0,dc726ff0,dc726e44,dc726e98,80050033) at netbsd:softint_dispatch+0xcc
 Bad frame pointer: 0xdc712f24
 cpu0: End traceback...
 fatal breackpoint trap in supervisor mode
 trap type 1 code 0 eip 0xc0115a94 cs 0x8 eflags 0x202 cr2 0xb6529020 ilevel 0x8 esp 0xdc723ed0
 curlwp 0xc4d78860 pid 0 lid 5 lowest kstack 0xdc7212c0
 
 ---
 Izumi Tsutsui