Re: PR/54730 CVS commit: src/usr.sbin/postinstall

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR bin/54730; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: PR/54730 CVS commit: src/usr.sbin/postinstall
Date: Sun, 22 Dec 2019 12:16:46 -0500

 --Apple-Mail=_C7E784E7-716F-489E-BE7F-DE35D890C1A6
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 
 > IIUC, etc.tgz is not extracted into ${DESTDIR} on upgrade =
 installation.
 > Then upgraded ${DESTDIR} doesn't have updated /var/db/obsolete/etc =
 data.
 >=20
 > That's the reason why obsolete /etc/rc.d/dhclient etc. won't
 > be removed even after postinstall(8) during upgrade.
 > That's the reason why etc set is special.
 
 Thanks for the explanation. I get it now. I think that this is the bug =
 there:
 We should be extracting at least the obsolete file (and perhaps =
 locate.database)
 from the etc set instead of doing special things in the postinstall =
 script because
 we are not even guaranteed to have the sources around.
 
 > You are pointing out style issue?  How should it be written?
 
 That is minor and I will take care of it. I just don't think it is the =
 right
 way to fix it because it does not work all the time and the decision
 whether to use the source instead of the installed files is done in
 another place. How hard would it be to fix the upgrade process instead =
 to
 extract those two files?
 
 christos
 
 --Apple-Mail=_C7E784E7-716F-489E-BE7F-DE35D890C1A6
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCXf+k/gAKCRBxESqxbLM7
 Oj7+AKDk6HEeo9a7IB7+RdFZbuik5B1osACcCXCmzvyjWZY8Ct0rhgfNKC08mb0=
 =FfRl
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_C7E784E7-716F-489E-BE7F-DE35D890C1A6--