Re: PR/54730 CVS commit: src/usr.sbin/postinstall

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR bin/54730; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: christos%zoulas.com@localhost
Cc: gnats-bugs%netbsd.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: PR/54730 CVS commit: src/usr.sbin/postinstall
Date: Mon, 23 Dec 2019 01:55:37 +0900

 > Yes, and I have not had time to understand and test it. I have not committed
 > anything because I don't want to make it worse. For example your latest
 > patch does something special for the "etc" set, and I don't understand how "etc"
 > is special.
 
 IIUC, etc.tgz is not extracted into ${DESTDIR} on upgrade installation.
 Then upgraded ${DESTDIR} doesn't have updated /var/db/obsolete/etc data.
 
 That's the reason why obsolete /etc/rc.d/dhclient etc. won't
 be removed even after postinstall(8) during upgrade.
 That's the reason why etc set is special.
 
 Warning messages during first boot after upgrade seems really
 annoying for users:
 > > /etc/rc: WARNING: $dhclient is not set properly - see rc.conf(5).
 > > /etc/rc: WARNING: $isdnd is not set properly - see rc.conf(5).
 and at least my patch suppress them.
 
 > Also obsolete_dir is only used in one part of the if statement and
 > should not be always set.
 
 You are pointing out style issue?  How should it be written?
 
 ---
 Izumi Tsutsui