[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-sparc64/54211: esiop stopped detecting boot disk
The following reply was made to PR port-sparc64/54211; it has been noted by GNATS.
From: Julian Coleman <jdc%coris.org.uk@localhost>
To: Jason Thorpe <thorpej%me.com@localhost>
Cc: "Michael L. Hitch" <mhitch%montana.edu@localhost>,
"Michael L. Hitch" <mhitch%netbsd.org@localhost>, gnats-bugs%netbsd.org@localhost,
Subject: Re: port-sparc64/54211: esiop stopped detecting boot disk
Date: Wed, 4 Dec 2019 16:46:41 +0100
> A working kernel shows:
> [ 1.0000000] gpio at iic0 addr 0x18 not configured
> While a failing kernel shows:
> [ 1.0000000] admtemp0 at iic0 addr 0x18: temperature sensor: id. 0xf0, rev.
> Rev 1.69 of i2c.c should be reverted. It is not correct, and was clearly made without an understanding of the semantics of the function in questions.
I think that it also makes sense to either remove indirect matching or make
admtemp more resistant to false matches. This would also cover other cases.
For example, dbcool.c already has such a check by calling dbcool_chip_ident()
from dbcool_match(). I think that we could add a similar function called
from admtemp_match() and also do the same for adm1026, where we already have
adm1026_ident() but don't call it from adm1026_match().
Main Index |
Thread Index |