Re: kern/52126 (mvsata Marvell 88SX6081 panics on boot)

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR kern/52126; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/52126 (mvsata Marvell 88SX6081 panics on boot)
Date: Thu, 31 Oct 2019 15:22:54 +0000

 Tinkering with today's -current/amd64, a probably not relevant
 
 Index: sys/dev/ic/wdc.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ic/wdc.c,v
 retrieving revision 1.294
 diff -u -p -r1.294 wdc.c
 --- sys/dev/ic/wdc.c    23 Oct 2019 14:44:41 -0000      1.294
 +++ sys/dev/ic/wdc.c    31 Oct 2019 15:17:20 -0000
 @@ -1210,6 +1210,7 @@ __wdcwait(struct ata_channel *chp, int m
         *tfd = 0;
  
         timeout = timeout * 1000 / WDCDELAY; /* delay uses microseconds */
 +       timeout *= 100; /* XXXPW */
  
         for (;;) {
                 status =
 
 and a
 
 include "arch/amd64/conf/GENERIC"
 options         DEBUG
 options         LOCKDEBUG
 options         ATADEBUG
 options         ATADEBUG_MASK=0x10
 options         MVSATA_DEBUG
 options         WDCNDELAY_DEBUG
 
 kernel, booting in uniprocessor mode, i.e., boot netbsd -1, I also hit
 the locking problem:
 
 panic: LOCKDEBUG: Mutex error: mutex_vector_enter,477: locking against myself
 
 db{0}> bt
 breakpoint() at netbsd:breakpoint+0x5
 vpanic() at netbsd:vpanic+0x178
 snprintf() at netbsd:snprintf
 lockdebug_more() at netbsd:lockdebug_more
 mutex_enter() at netbsd:mutex_enter+0x518
 ata_queue_get_active_xfer() at netbsd:ata_queue_get_active_xfer+0x16
 __wdcwait() at netbsd:__wdcwait+0x116
 wdcwait() at netbsd:wdcwait+0x99
 __wdccommand_intr() at netbsd:__wdccommand_intr+0xc4
 ata_xfer_start() at netbsd:ata_xfer_start+0x136
 atastart() at netbsd:atastart+0x20e
 wdc_exec_command() at netbsd:wdc_exec_command+0x9a
 ata_get_params() at netbsd:ata_get_params+0x11e
 wdc_drvprobe() at netbsd:wdc_drvprobe+0x3cb
 atabusconfig() at netbsd:atabusconfig+0x65
 atabus_thread() at netbsd:atabus_thread+0x81
 db{0}> show locks
 [Locks tracked through LWPs]
 Locks held by an LWP (ipmi0):
 Lock 0 (initialized at ipmi_attach)
 lock address : 0xfffffe226d5333c0 type     :     sleep/adaptive
 initialized  : 0xffffffff80a9285c
 shared holds :                  0 exclusive:                  1
 shares wanted:                  0 exclusive:                  0
 current cpu  :                  0 last held:                  0
 current lwp  : 0xfffffe1f2f053a40 last held: 0xfffffe226d53e540
 last locked* : 0xffffffff80a93498 unlocked : 000000000000000000
 owner field  : 0xfffffe226d53e540 wait/spin:                0/0
 
 Turnstile chain at 0xffffffff816a0480.
 => No active turnstile for this lock.
 
 
 [Locks tracked through CPUs]
 Locks held on CPU 0:
 Lock 0 (initialized at main)
 lock address : 0xffffffff8169ea80 type     :               spin
 initialized  : 0xffffffff80e3cca9
 shared holds :                  0 exclusive:                  1
 shares wanted:                  0 exclusive:                  0
 current cpu  :                  0 last held:                  0
 current lwp  : 0xfffffe1f2f053a40 last held: 0xfffffe1f2f053a40
 last locked* : 0xffffffff80209781 unlocked : 0xffffffff809ca113
 curcpu holds :                  1 wanted by: 000000000000000000
 
 Lock 1 (initialized at ata_channel_init)
 lock address : 0xffffad801da5f1f0 type     :               spin
 initialized  : 0xffffffff8028424c
 shared holds :                  0 exclusive:                  1
 shares wanted:                  0 exclusive:                  1
 current cpu  :                  0 last held:                  0
 current lwp  : 0xfffffe1f2f053a40 last held: 0xfffffe1f2f053a40
 last locked* : 0xffffffff8063b9d8 unlocked : 0xffffffff8028070c
 owner field  : 0x0000000000010600 wait/spin:                0/1
 
 db{0}> ps
 PID    LID S CPU     FLAGS       STRUCT LWP *               NAME WAIT
 0    >  40 7   0       200   fffffe1f2f053a40           atabus16
 0       21 3   0       200   fffffe226d53e540              ipmi0 ipmicmd