Re: kern/54541: kernel panic using "zfs diff"

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/54541; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/54541: kernel panic using "zfs diff"
Date: Wed, 9 Oct 2019 13:03:29 -0400

 On Oct 9,  3:55pm, prlw1%cam.ac.uk@localhost (Patrick Welche) wrote:
 -- Subject: Re: kern/54541: kernel panic using "zfs diff"
 
 | The following reply was made to PR kern/54541; it has been noted by GNATS.
 | 
 | From: Patrick Welche <prlw1%cam.ac.uk@localhost>
 | To: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 | 	netbsd-bugs%netbsd.org@localhost, joernc%posteo.de@localhost
 | Cc: 
 | Subject: Re: kern/54541: kernel panic using "zfs diff"
 | Date: Wed, 9 Oct 2019 16:52:16 +0100
 | 
 |  src/external/cddl/osnet/dist/lib/libzfs/common/libzfs_diff.c:
 |     739  static int
 |     740  setup_differ_info(zfs_handle_t *zhp, const char *fromsnap,
 |     741      const char *tosnap, differ_info_t *di)
 |     742  {
 |     743          di->zhp = zhp;
 |     744  
 |     745          di->cleanupfd = open(ZFS_DEV, O_RDWR|O_EXCL);
 |     746          VERIFY(di->cleanupfd >= 0);
 |     747  
 |     748          if (get_snapshot_names(di, fromsnap, tosnap) != 0)
 |     749                  return (-1);
 |     750  
 |     751          if (get_mountpoints(di) != 0)
 |     752                  return (-1);
 |     753  
 |     754          if (find_shares_object(di) != 0)
 |     755                  return (-1);
 |     756  
 |     757          return (0);
 |     758  }
 |  
 |  so cleanupfd=133 should be OK?
 
 https://nxr.netbsd.org/xref/src/lib/librumphijack/hijack.c#433
 
 Something seems to not understand that this is a hijacked fd which it seems
 to be: 133 (128 + 5)...
 
 christos