Re: bin/54574: usr.bin/make/parse.c $Id: 1.231 drops core on NetBSD-5.2 in realpath(3)

["Simon J. Gerraty" <sjg%juniper.net@localhost>]

The following reply was made to PR toolchain/54574; it has been noted by GNATS.

From: "Simon J. Gerraty" <sjg%juniper.net@localhost>
To: <gnats-bugs%netbsd.org@localhost>
Cc: <gnats-admin%netbsd.org@localhost>, <netbsd-bugs%netbsd.org@localhost>, <buhrow%nfbcal.org@localhost>,
        <sjg%juniper.net@localhost>
Subject: Re: bin/54574: usr.bin/make/parse.c $Id: 1.231 drops core on NetBSD-5.2 in realpath(3)
Date: Mon, 30 Sep 2019 14:07:33 -0700

 David Holland <dholland-bugs%netbsd.org@localhost> wrote:
 >  On Thu, Sep 26, 2019 at 08:00:02PM +0000, Simon J. Gerraty wrote:
 >   >   {
 >   >   	static Boolean fatal_warning_error_printed = FALSE;
 >   >  +	char dirbuf[MAXPATHLEN+1];
 >  
 >  nit: please use PATH_MAX (more portable) and it doesn't need +1 as it
 >  is defined to include space for a null terminator.
 
 FWIW I used MAXPATHLEN because that's what the rest of make is using.
 
 The portability issue is probably somewhat moot for bmake 
 since make.h ensures both MAXPATHLEN and PATH_MAX are defined -
 potentially in terms of BMAKE_PATH_MAX
 
 Thanks
 --sjg