Re: misc/54581: Issues building NetBSD-9 under NetBSD-5.2

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR misc/54581; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: misc/54581: Issues building NetBSD-9 under NetBSD-5.2
Date: Sat, 28 Sep 2019 15:03:55 +0700

     Date:        Sat, 28 Sep 2019 00:30:01 +0000 (UTC)
     From:        Brian Buhrow <buhrow%nfbcal.org@localhost>
     Message-ID:  <20190928003001.AE24C7A23E%mollari.NetBSD.org@localhost>
 
 
   |   #if HAVE_SYS_CDEFS_H
   |   #include <sys/cdefs.h>
   |  +/* 
   |  + * __CTASSERT isn't defined until NetBSD-6, allow builds that want it
   |  + * to build on NetBSD-5 and older.
   |  + */
   |  +#if (defined(__NetBSD_Version__) && __NetBSD_Version__ < 600000000)
 
 That would be better done as
 	#ifndef __CTASSERT
 
   |  +#define	__CTASSERT1(x, y, z)	typedef char y ## z[/*CONSTCOND*/(x) ? 1 : -1]
 
 And that one the way it is done now in HEAD, rather than that old way
 (though for this purpose it doesn't matter all that much, in fact, for
 the purpose, simply defining __CTASSERT() to generate nothing would do).
 
 kre