PR/54495 CVS commit: [netbsd-9] src/sys/dev/usb

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR kern/54495; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54495 CVS commit: [netbsd-9] src/sys/dev/usb
Date: Fri, 13 Sep 2019 06:51:59 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Sep 13 06:51:59 UTC 2019
 
 Modified Files:
 	src/sys/dev/usb [netbsd-9]: if_upl.c if_url.c if_urndis.c usb_mem.c
 	    usbnet.c usbnet.h
 
 Log Message:
 Pull up following revision(s) (requested by mrg in ticket #197):
 
 	sys/dev/usb/if_url.c: revision 1.71
 	sys/dev/usb/usbnet.h: revision 1.15
 	sys/dev/usb/usb_mem.c: revision 1.72
 	sys/dev/usb/if_urndis.c: revision 1.24
 	sys/dev/usb/if_upl.c: revision 1.67
 	sys/dev/usb/usbnet.c: revision 1.25
 	sys/dev/usb/usbnet.c: revision 1.26
 	sys/dev/usb/usbnet.c: revision 1.27
 	sys/dev/usb/usbnet.c: revision 1.28
 
 Teach urndis to handle some REMOTE_NDIS_INDICATE_STATUS_MSG. If the status
 is reasonable, don't tell userland we got an error. Stops spurious EIO.
 From openbsd.
 
 Fix bug, remove {0,0} because we switched to usb_lookup().
 
 s/no free/no freelist entry/ in a debug message.
 
 fix a lock hang reported by sc.dying in PR#54495.
 
 remove locking in usbnet_tick().  assume that all locking
 needs are handled inside usbnet_tick_task(), which runs in
 the usbtask thread.  ensure that usbnet private is valid
 before using it.
 
 also check NULL private pointer in usbnet_isdying().
 all the other cases should never happen.
 
 don't try to set dying when we haven't usbnet_attach()d yet.
 reported by maxv.
 
 - use CALLARGS vs CALLED for better usbhist
 - turn off usbnetdebug default
 - log for all entry/exit points of usbnet_pipe_intr()
 - in usbnet_start_locked() track whether any packet has been
   transmitted for setting the timer.  avoids spurious
   "watchdog timeouts"
 - in usbnet_stop() use callout_halt() vs callout_halt, and
   also stop the usb task.  fixes crash of usbtask after the
   phy has detached.
 - add a little more defensive checking in the tick task, and
   add some high-log-level logs.
 - in usbnet_detach() move the call to usbnet_stop_ifp() above
   the calls to callout/usbtask stopping.
 - set ec_mii and unp_pri to NULL when freeing their data
 
 normalise an error message.
 
 document usbnet_private locking.  minor knf.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.64.2.1 -r1.64.2.2 src/sys/dev/usb/if_upl.c
 cvs rdiff -u -r1.66.2.1 -r1.66.2.2 src/sys/dev/usb/if_url.c
 cvs rdiff -u -r1.21.4.1 -r1.21.4.2 src/sys/dev/usb/if_urndis.c
 cvs rdiff -u -r1.70.10.1 -r1.70.10.2 src/sys/dev/usb/usb_mem.c
 cvs rdiff -u -r1.25.2.2 -r1.25.2.3 src/sys/dev/usb/usbnet.c
 cvs rdiff -u -r1.14.2.2 -r1.14.2.3 src/sys/dev/usb/usbnet.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.