Re: kern/54474: Jetson TK1 audio playback has clicks since isaki-audio2 merge

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

The following reply was made to PR kern/54474; it has been noted by GNATS.

From: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
To: gnats-bugs%netbsd.org@localhost, isaki%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/54474: Jetson TK1 audio playback has clicks since
 isaki-audio2 merge
Date: Wed, 4 Sep 2019 15:45:57 +0100

 On 03/09/2019 13:10, Tetsuya Isaki wrote:> The following reply was made
 to PR kern/54474; it has been noted by GNATS.
  >
  > From: Tetsuya Isaki <isaki%pastel-flower.jp@localhost>
  > To: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
  > Cc: gnats-bugs%netbsd.org@localhost,
  > 	gnats-admin%netbsd.org@localhost,
  > 	netbsd-bugs%netbsd.org@localhost
  > Subject: Re: kern/54474: Jetson TK1 audio playback has clicks since
 isaki-audio2 merge
  > Date: Tue, 03 Sep 2019 21:08:20 +0900
  >
  >   At Sat, 31 Aug 2019 21:51:23 +0100,
  >   Nick Hudson wrote:
  >   > tk1# audiocfg test 0
  >   > 0: [*] audio0 @ hdafg0: NVIDIA Tegra124 HDMI
  >   >         playback: 8ch, 44100Hz
  >   >         record:   2ch, 44100Hz
  >   >         (P-) slinear_le 16/16, 2ch, { 44100 }
  >   >         (P-) slinear_le 16/16, 4ch, { 44100 }
  >   >         (P-) slinear_le 16/16, 6ch, { 44100 }
  >   >         (P-) slinear_le 16/16, 8ch, { 44100 }
  >   >         (PR) slinear_le 16/16, 2ch, 44100-44100Hz
  >   >    testing channel 0... done
  >   >    testing channel 1... done
  >   >    testing channel 2... done
  >   >    testing channel 3... done
  >   >    testing channel 4... done
  >   >    testing channel 5... done
  >   >    testing channel 6... done
  >   >    testing channel 7... done
  >   > tk1#
  >
  >   Thank you for complementing my missing information.
  >   And the problem "write: Resouce temporarily unavailable" seems gone.
  >   (It's small but good thing to me.)
 I agree it's good :)
 
 
  >
  >   > The audio is still "clicky"/distorted in some way.
  >   :
  >   > I couldn't hear any audio with this, but then the tk1's fan is
 really noisy.
  >   >
  >   > Something is still no quite right with audiocfg test audio output.
  >
  >   Hmm, what happens in 2channels mode instead of 8channels mode?
  >   You can change it by following command on netbsd-9:
  >     # audiocfg set 0 p slinear_le 16 2 41000
 
 tk1#  audiocfg set 0 p slinear_le 16 2 41000
 setting audio0 to slinear_le:16,[ 194.9778959] audio0: slinear_le:16 8ch
 44100Hz, blk 40ms for playback
 [ 194.9878987] audio0: slinear_le:16 2ch 44100Hz, blk 40ms for recording
   2ch, 41000Hz
 ioctl AUDIO_SETFORMAT: Invalid argument
 couldn't set parameter: Invalid argument
 tk1#
 
 
 
  >     # audiocfg test 0
  >
  >   Next, would you try the following patch (to netbsd-9)?
  >   This reverts a part of changes I made in isaki-audio2 branch.  The
  >   patch should not improve your problem but I want to confirm it.
 It sounds OK with the patch!
 
 I can send you recording of before and after if you want, but the patch
 seems to fix it.
 
 Thanks,
 Nick