PR/54480 CVS commit: src/usr.sbin/sysinst

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR install/54480; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54480 CVS commit: src/usr.sbin/sysinst
Date: Tue, 20 Aug 2019 06:38:18 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Aug 20 06:38:18 UTC 2019
 
 Modified Files:
 	src/usr.sbin/sysinst: disks.c
 
 Log Message:
 PR install/54480: when upgrading a system and re-mounting the target /
 with proper options, and the installed system does not use NAME= syntax
 in fstab(5), use the device name we used to get here, instead of the
 name from fstab, it might be different to what the real system calls the
 device (compact flash root showing up as wd0 native, but sd? on the
 card reader used for updating it right now).
 
 This is an abuse of the upgrade functionality and in general pretty dangerous
 when multiple devices are used in the upgraded fstab (e.g. separate /usr),
 and it used to work more by accident with the old code.
 
 However, it is a quite usefull way to upgrade tiny systems with compact flash
 root, and it used to work - so support it properly (as far as we can).
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.50 -r1.51 src/usr.sbin/sysinst/disks.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.