bin/54468: Wrong tar(1) man page getting installed

[paul%whooppee.com@localhost]

>Number:         54468
>Category:       bin
>Synopsis:       Wrong version of tar(1) man page gets installed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 15 18:50:00 +0000 2019
>Originator:     Paul Goyette
>Release:        NetBSD 9.99.4
>Organization:
+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+
>Environment:
	
	
System: NetBSD speedy.whooppee.com 9.99.4 NetBSD 9.99.4 (SPEEDY 2019-08-08 19:47:57 UTC) #1: Thu Aug 8 20:23:24 UTC 2019 paul%speedy.whooppee.com@localhost:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
Recent builds (with sources from after the change to MKBSDTAR=yes) are
still installing the tar.1 man page from src/bin/pax rather than the
page from src/external/bsd/libarchive/

In actuality it seems that _both_ versions of the man page are being
installed, but the pax-version comes last.

Here's my build.sh command;  note use of -n0 for maximum noise/detail
and -j1.  The -j1 might be significant, since the log below clearly
shows that two different copies of tar.1 were installed.  Since this
problem doesn't seem to occur on production releng builds, it is quite
possible that, with more parallel jobs, the two installs could occur
in a different order.

./build.sh \
	-T /build/netbsd-compat/tools/x86_64/amd64 \
	-D /build/netbsd-compat/dest/amd64 \
	-O /build/netbsd-compat/obj/amd64 \
	-R /build/netbsd-compat/release \
	-V RELEASEMACHINEDIR=amd64 -V MKDEBUG=yes -V MKKDEBUG=yes \
	-U -N2 -m amd64 -j1 release


And here's the result of 'grep tar\.1 release.log'


(cd /build/netbsd-compat/src_ro/external/bsd/libarchive/bin/tar && rm -f tar.1 a.out [Ee]rrs mklog core *.core .gdbinit   tar tar.debug bsdtar.o cmdline.o creation_set.o read.o subst.o util.o write.o  bsdtar.ln cmdline.ln creation_set.ln read.ln subst.ln util.ln write.ln || true) 
/build/netbsd-compat/tools/x86_64/amd64/bin/nbcat /build/netbsd-compat/src_ro/external/bsd/libarchive/dist/tar/bsdtar.1 > tar.1
if test "" != "yes"; then  /build/netbsd-compat/tools/x86_64/amd64/bin/nbmandoc -Thtml -Oman=../html%S/%N.html,style=../style.css  tar.1 > tar.html1.tmp &&  mv -f tar.html1.tmp tar.html1;  else  GROFF_ENCODING=  GROFF_BIN_PATH=/build/netbsd-compat/tools/x86_64/amd64/lib/groff  GROFF_FONT_PATH=/build/netbsd-compat/tools/x86_64/amd64/share/groff/site-font:/build/netbsd-compat/tools/x86_64/amd64/share/groff/font  GROFF_TMAC_PATH=/build/netbsd-compat/tools/x86_64/amd64/share/groff/site-tmac:/build/netbsd-compat/tools/x86_64/amd64/share/groff/tmac /build/netbsd-compat/tools/x86_64/amd64/bin/nbgroff  -Tlatin1 -mdoc2html tar.1   > tar.html1.tmp && mv -f tar.html1.tmp tar.html1;  fi
if test "" != "yes"; then  /build/netbsd-compat/tools/x86_64/amd64/bin/nbmandoc -Thtml -Oman=../html%S/%N.html,style=../style.css  /build/netbsd-compat/src_ro/bin/pax/tar.1 > tar.html1.tmp &&  mv -f tar.html1.tmp tar.html1;  else  GROFF_ENCODING=  GROFF_BIN_PATH=/build/netbsd-compat/tools/x86_64/amd64/lib/groff  GROFF_FONT_PATH=/build/netbsd-compat/tools/x86_64/amd64/share/groff/site-font:/build/netbsd-compat/tools/x86_64/amd64/share/groff/font  GROFF_TMAC_PATH=/build/netbsd-compat/tools/x86_64/amd64/share/groff/site-tmac:/build/netbsd-compat/tools/x86_64/amd64/share/groff/tmac /build/netbsd-compat/tools/x86_64/amd64/bin/nbgroff  -Tlatin1 -mdoc2html /build/netbsd-compat/src_ro/bin/pax/tar.1   > tar.html1.tmp && mv -f tar.html1.tmp tar.html1;  fi
#   install  /build/netbsd-compat/dest/amd64/usr/share/man/man1/tar.1
/build/netbsd-compat/tools/x86_64/amd64/bin/x86_64--netbsd-install -U -M /build/netbsd-compat/dest/amd64/METALOG -D /build/netbsd-compat/dest/amd64 -h sha256 -N /build/netbsd-compat/src_ro/etc -c  -r -o root -g wheel -m 444  tar.1 /build/netbsd-compat/dest/amd64/usr/share/man/man1/tar.1
#   install  /build/netbsd-compat/dest/amd64/usr/share/man/man1/tar.1
/build/netbsd-compat/tools/x86_64/amd64/bin/x86_64--netbsd-install -U -M /build/netbsd-compat/dest/amd64/METALOG -D /build/netbsd-compat/dest/amd64 -h sha256 -N /build/netbsd-compat/src_ro/etc -c  -r -o root -g wheel -m 444  /build/netbsd-compat/src_ro/bin/pax/tar.1 /build/netbsd-compat/dest/amd64/usr/share/man/man1/tar.1

>How-To-Repeat:
	
>Fix:
	

>Unformatted: