NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: lib/54329: libedit: undefined terminal behavior in terminal_move_to_line (fix included)
The following reply was made to PR lib/54329; it has been noted by GNATS.
From: Christos Zoulas <christos%zoulas.com@localhost>
To: Valery Ushakov <uwe%stderr.spb.ru@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: lib/54329: libedit: undefined terminal behavior in
terminal_move_to_line (fix included)
Date: Sun, 30 Jun 2019 09:23:24 -0400
I could not reproduce it, but I've seen it before. In the end the =
optimization is probably not worth the complexity.
This code was written 30 years ago where the cost of each character was =
high at 2400 or 9600 baud. It is also
unclear that the cost/benefit warrants the complexity in the frequently =
used cases. For example on an xterm,
the DO sequence is "\e[%p1%dB" which would take quite a few lines (> 5 =
if I counted right with 0 padding), to
exceed the cost of just printing line feeds. So unless am I missing =
something, we don't lose much by skipping
the optimization.
christos=
Home |
Main Index |
Thread Index |
Old Index