Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR port-arm/54153; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK
Date: Mon, 10 Jun 2019 05:26:14 +0000

 This chain wasn't sent to gnats (please be sure bug traffic is sent to
 gnats-bugs)
 
    ------
 
 From: Ryota Ozaki <ozaki-r%netbsd.org@localhost>
 To: sc dying <sc.dying%gmail.com@localhost>
 Cc: port-arm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 	netbsd-bugs%netbsd.org@localhost
 Subject: Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK
 Date: Wed, 8 May 2019 19:09:16 +0900
 
 On Fri, May 3, 2019 at 12:00 PM sc dying <sc.dying%gmail.com@localhost> wrote:
 >
 > >Number:         54153
 > >Category:       port-arm
 > >Synopsis:       emac multicast hash calculation needs ETHER_LOCK
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       high
 > >Responsible:    port-arm-maintainer
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Fri May 03 03:00:00 +0000 2019
 > >Originator:     sc dying <sc.dying%gmail.com@localhost>
 > >Release:        NetBSD 8.99.37
 > >Organization:
 > >Environment:
 > System: NetBSD 8.99.37 evbarm
 > Architecture: earmv7hf
 > Machine: evbarm
 > Boardtype: NanoPi neo
 > >Description:
 > sunxi emac(4) multicast hash calculation needs wrapped with
 > ETHER_LOCK - ETHER_UNLOCK, especially if NET_MPSAFE is defined.
 >
 > >How-To-Repeat:
 >
 > >Fix:
 > Please add ETHER_LOCK before ETHER_FIRST_MULTI and add ETHER_UNLOCK
 > after following while loop.
 
 Fixed, thanks.
 
 >
 > Please pull-up to 8.0, too.
 
 Have you encountered any issues around the code?  Even if NET_MPSAFE is enabled
 emac(4) is protected with KERENL_LOCK AFAIK so the code is actually
 not problematic
 on netbsd-8.  (I fixed it on -current for further MP-ification in the future.)
 
   ozaki-r
 
 
 From: sc dying <sc.dying%gmail.com@localhost>
 To: Ryota Ozaki <ozaki-r%netbsd.org@localhost>
 Cc: port-arm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 	netbsd-bugs%netbsd.org@localhost
 Subject: Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK
 Date: Wed, 8 May 2019 23:03:10 +0900
 
 On Wed, May 8, 2019 at 7:09 PM Ryota Ozaki <ozaki-r%netbsd.org@localhost> wrote:
 > > >Description:
 > > sunxi emac(4) multicast hash calculation needs wrapped with
 > > ETHER_LOCK - ETHER_UNLOCK, especially if NET_MPSAFE is defined.
 > >
 > > >How-To-Repeat:
 > >
 > > >Fix:
 > > Please add ETHER_LOCK before ETHER_FIRST_MULTI and add ETHER_UNLOCK
 > > after following while loop.
 >
 > Fixed, thanks.
 
 Thank you for fix, but I should tell which driver needs fixed.
 I did not notice arm/sunxi/ have two emac driver, {sun4i,sunxi}_emac.c.
 I thought my nanopi (sun8i-h3-nanopi-neo) uses sunxi_emac.c and
 looked into it.
 sunxi_emac.c has the same problem that sun4i_emac.c had.
 Could you fix sunxi_emac.c too?
 
 >
 > >
 > > Please pull-up to 8.0, too.
 >
 > Have you encountered any issues around the code?  Even if NET_MPSAFE is enabled
 > emac(4) is protected with KERENL_LOCK AFAIK so the code is actually
 > not problematic
 > on netbsd-8.  (I fixed it on -current for further MP-ification in the future.)
 
 I don't have any problem about this, but just notice by looking into
 another problem.
 
 
 From: Ryota Ozaki <ozaki-r%netbsd.org@localhost>
 To: sc dying <sc.dying%gmail.com@localhost>
 Cc: port-arm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 	netbsd-bugs%netbsd.org@localhost
 Subject: Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK
 Date: Thu, 9 May 2019 11:08:15 +0900
 
 On Wed, May 8, 2019 at 11:02 PM sc dying <sc.dying%gmail.com@localhost> wrote:
 >
 > On Wed, May 8, 2019 at 7:09 PM Ryota Ozaki <ozaki-r%netbsd.org@localhost> wrote:
 > > > >Description:
 > > > sunxi emac(4) multicast hash calculation needs wrapped with
 > > > ETHER_LOCK - ETHER_UNLOCK, especially if NET_MPSAFE is defined.
 > > >
 > > > >How-To-Repeat:
 > > >
 > > > >Fix:
 > > > Please add ETHER_LOCK before ETHER_FIRST_MULTI and add ETHER_UNLOCK
 > > > after following while loop.
 > >
 > > Fixed, thanks.
 >
 > Thank you for fix, but I should tell which driver needs fixed.
 > I did not notice arm/sunxi/ have two emac driver, {sun4i,sunxi}_emac.c.
 > I thought my nanopi (sun8i-h3-nanopi-neo) uses sunxi_emac.c and
 > looked into it.
 > sunxi_emac.c has the same problem that sun4i_emac.c had.
 > Could you fix sunxi_emac.c too?
 
 Oh, I didn't notice the driver.  I fixed it now.
 
 >
 > >
 > > >
 > > > Please pull-up to 8.0, too.
 > >
 > > Have you encountered any issues around the code?  Even if NET_MPSAFE is enabled
 > > emac(4) is protected with KERENL_LOCK AFAIK so the code is actually
 > > not problematic
 > > on netbsd-8.  (I fixed it on -current for further MP-ification in the future.)
 >
 > I don't have any problem about this, but just notice by looking into
 > another problem.
 
 Actually sunxi_emac.c is racy with NET_MPSAFE, so I'll pull the fix up
 to netbsd-8.
 
 Thank you for the report!
   ozaki-r
 
 
 From: sc dying <sc.dying%gmail.com@localhost>
 To: Ryota Ozaki <ozaki-r%netbsd.org@localhost>
 Cc: port-arm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 	netbsd-bugs%netbsd.org@localhost
 Subject: Re: port-arm/54153: emac multicast hash calculation needs ETHER_LOCK
 Date: Thu, 9 May 2019 05:50:47 +0000
 
 On Thu, May 9, 2019 at 2:08 AM Ryota Ozaki <ozaki-r%netbsd.org@localhost> wrote:
 >
 > On Wed, May 8, 2019 at 11:02 PM sc dying <sc.dying%gmail.com@localhost> wrote:
 > >
 > > On Wed, May 8, 2019 at 7:09 PM Ryota Ozaki <ozaki-r%netbsd.org@localhost> wrote:
 > > > > >Description:
 > > > > sunxi emac(4) multicast hash calculation needs wrapped with
 > > > > ETHER_LOCK - ETHER_UNLOCK, especially if NET_MPSAFE is defined.
 > > > >
 > > > > >How-To-Repeat:
 > > > >
 > > > > >Fix:
 > > > > Please add ETHER_LOCK before ETHER_FIRST_MULTI and add ETHER_UNLOCK
 > > > > after following while loop.
 > > >
 > > > Fixed, thanks.
 > >
 > > Thank you for fix, but I should tell which driver needs fixed.
 > > I did not notice arm/sunxi/ have two emac driver, {sun4i,sunxi}_emac.c.
 > > I thought my nanopi (sun8i-h3-nanopi-neo) uses sunxi_emac.c and
 > > looked into it.
 > > sunxi_emac.c has the same problem that sun4i_emac.c had.
 > > Could you fix sunxi_emac.c too?
 >
 > Oh, I didn't notice the driver.  I fixed it now.
 
 Thanks a lot!
 
 >
 > >
 > > >
 > > > >
 > > > > Please pull-up to 8.0, too.
 > > >
 > > > Have you encountered any issues around the code?  Even if NET_MPSAFE is enabled
 > > > emac(4) is protected with KERENL_LOCK AFAIK so the code is actually
 > > > not problematic
 > > > on netbsd-8.  (I fixed it on -current for further MP-ification in the future.)
 > >
 > > I don't have any problem about this, but just notice by looking into
 > > another problem.
 >
 > Actually sunxi_emac.c is racy with NET_MPSAFE, so I'll pull the fix up
 > to netbsd-8.
 >
 > Thank you for the report!
 >   ozaki-r