Re: kern/54264: audio(4) API fails to detect a capture-only device

[Tetsuya Isaki <isaki%pastel-flower.jp@localhost>]

The following reply was made to PR kern/54264; it has been noted by GNATS.

From: Tetsuya Isaki <isaki%pastel-flower.jp@localhost>
To: Takeshi Nakayama <nakayama%NetBSD.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost,
	kern-bug-people%netbsd.org@localhost,
	gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/54264: audio(4) API fails to detect a capture-only device
Date: Thu, 06 Jun 2019 21:48:04 +0900

 At Thu, 06 Jun 2019 10:25:54 +0900 (JST),
 Takeshi Nakayama wrote:
 > The patch for uaudio.c works well on my USB speaker.
 > 
 > Rev.1.7 of audio.c is workaround, so I agree with reverting it.
 
 Thank you.
 
 > But I don't think rev.1.5 is completely wrong.  Variable error is
 > used for result of both audio_hw_probe_fmt(..., AUMODE_PLAY) and
 > audio_hw_probe_fmt(..., AUMODE_RECORD), so the result for
 > AUMODE_PLAY is overwritten by its for AUMODE_RECORD.
 > 
 > I think both errors should be checked and audio_hw_probe returns
 > error if both are in error as of rev.1.5, or if one or the other is
 > in error.
 
 Oh, it's my wrong about rev1.5, sorry.
 
 > Also, if such a strange hardware driver should be fixed, I think
 > that you should add KASSERT or else to detect such a driver.
 
 Yeah I will do so.
 (I should have written about it in my previous mail..)
 
 Thanks,
 ---
 Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>