PR/54158 CVS commit: src/sys/kern

[Anthony Mallet <tho%netbsd.org@localhost>]

The following reply was made to PR kern/54158; it has been noted by GNATS.

From: Anthony Mallet <tho%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: PR/54158 CVS commit: src/sys/kern
Date: Tue, 7 May 2019 21:36:13 +0200

 On Saturday  4 May 2019, at 15:50, Christos Zoulas wrote:
 >  Modified Files:
 >  	src/sys/kern: sys_select.c
 >
 >  Log Message: PR/54158: Anthony Mallet: poll(2) does not allow
 >  polling all possible fds (hardcoded limit to 1000 +
 >  #<open-fds>). Changed to limit by the max of the resource limit of
 >  open descriptors and the above.
 
 Thanks!
 
 I'm fine with sys_select.c rev. 1.43.
 
 Even though
 http://mail-index.netbsd.org/source-changes-d/2019/05/06/msg011270.html
 makes a lot a sense, I think there is no need to change the test
 further, because POSIX (and Linux, for that matter) implicitly state
 that poll(2) might return EINVAL if "The nfds argument is greater than
 {OPEN_MAX}".  (see http://pubs.opengroup.org/onlinepubs/9699919799/)
 
 What about using "rlim_max" instead of "rlim_cur"? This would be more
 inline with "{OPEN_MAX}", and this would partially handle the point
 made by kre@ in his message above.