Re: bin/54068: ATF tests hung in pipe2_consume

[Michael van Elst <mlelstv%serpens.de@localhost>]

The following reply was made to PR bin/54068; it has been noted by GNATS.

From: Michael van Elst <mlelstv%serpens.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/54068: ATF tests hung in pipe2_consume
Date: Fri, 26 Apr 2019 19:04:55 +0200

 It's a bug in the pipe code that is excercised by the atf test.
 
 When pipe creation fails, pipe1() calls pipeclose() to clean up the partially
 initialized pipe structures. pipeclose() however relies on the pipe_peer
 field to be valid or zero.
 
 Another error path exists for the pipe_lock field.
 
 The fix is to clear both fields before recycling a pipe structure.
 
 
 Greetings,
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."