PR/54112 CVS commit: src

["Robert Elz" <kre%netbsd.org@localhost>]

The following reply was made to PR bin/54112; it has been noted by GNATS.

From: "Robert Elz" <kre%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54112 CVS commit: src
Date: Wed, 10 Apr 2019 08:13:11 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Wed Apr 10 08:13:11 UTC 2019
 
 Modified Files:
 	src/bin/sh: expand.c
 	src/tests/bin/sh: t_expand.sh
 
 Log Message:
 PR bin/54112
 
 Fix handling of "$@" (that is, double quoted dollar at), when it
 appears in a string which will be subject to field splitting.
 
 Eg:
 	${0+"$@" }
 
 More common usages, like the simple "$@" or ${0+"$@"} end up
 being entirely quoted, so no field splitting happens, and the
 problem was avoided.
 
 See the PR for more details.
 
 This ends up making a bunch of old hack code (and some that was
 relatively new) vanish - for now it is just #if 0'd or commented out.
 Cleanups of that stuff will happen later.
 
 That some of the worst $@ hacks are now gone does not mean that processing
 of "$@" does not retain a very special place in every hackers heart.
 RIP extreme ugliness - long live the merely ordinary ugly.
 
 Added a new bin/sh ATF test case to verify that all this remains fixed.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.131 -r1.132 src/bin/sh/expand.c
 cvs rdiff -u -r1.20 -r1.21 src/tests/bin/sh/t_expand.sh
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.