Re: bin/53705: dhcpcd spams syslogd

[Roy Marples <roy%marples.name@localhost>]

The following reply was made to PR bin/53705; it has been noted by GNATS.

From: Roy Marples <roy%marples.name@localhost>
To: gnats-bugs%netbsd.org@localhost, roy%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost, kre%munnari.OZ.AU@localhost
Cc: 
Subject: Re: bin/53705: dhcpcd spams syslogd
Date: Tue, 9 Apr 2019 12:25:20 +0100

 This is a multi-part message in MIME format.
 --------------3F76325E9495F45A3CC31F97
 Content-Type: text/plain; charset=utf-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 On 09/04/2019 01:30, Robert Elz wrote:
 >   In any case, when an "error" like this occurs, and repeats, there's no
 >   point continually telling the world about it every time - after it has
 >   happened a couple of times, simply stop sending error reports until
 >   something changes (until an address does get assigned, or until the
 >   dhcpcd process restarts, or something).
 
 Try the attached patch.
 The only problem with it is that if dhcpcd is configured to request >1 
 IA and one of them gets an invalid status then dhcpcd will still be spammy.
 
 Let me know if it helps your situation at least.
 
 Roy
 
 --------------3F76325E9495F45A3CC31F97
 Content-Type: text/plain; charset=UTF-8;
  name="dhcpcd-dhcpv6-spam.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="dhcpcd-dhcpv6-spam.diff"
 
 ZGlmZiAtLWdpdCBhL3NyYy9kaGNwNi5jIGIvc3JjL2RoY3A2LmMKaW5kZXggY2MyMjY3ODcu
 Ljk5YTQ1MmJiIDEwMDY0NAotLS0gYS9zcmMvZGhjcDYuYworKysgYi9zcmMvZGhjcDYuYwpA
 QCAtMTkxMywxMyArMTkxMywxNiBAQCBzdGF0aWMgaW50CiBkaGNwNl9jaGVja3N0YXR1c29r
 KGNvbnN0IHN0cnVjdCBpbnRlcmZhY2UgKmlmcCwKICAgICBzdHJ1Y3QgZGhjcDZfbWVzc2Fn
 ZSAqbSwgdWludDhfdCAqcCwgc2l6ZV90IGxlbikKIHsKKwlzdHJ1Y3QgZGhjcDZfc3RhdGUg
 KnN0YXRlOwogCXVpbnQ4X3QgKm9wdDsKIAl1aW50MTZfdCBvcHRfbGVuLCBjb2RlOwogCXNp
 emVfdCBtbGVuOwogCXZvaWQgKiAoKmYpKHZvaWQgKiwgc2l6ZV90LCB1aW50MTZfdCwgdWlu
 dDE2X3QgKiksICpmYXJnOwogCWNoYXIgYnVmWzMyXSwgKnNidWY7CiAJY29uc3QgY2hhciAq
 c3RhdHVzOworCWxvZ2Z1bmNfdCAqbG9nZnVuYzsKIAorCXN0YXRlID0gRDZfU1RBVEUoaWZw
 KTsKIAlmID0gcCA/IGRoY3A2X2ZpbmRvcHRpb24gOiBkaGNwNl9maW5kbW9wdGlvbjsKIAlp
 ZiAocCkKIAkJZmFyZyA9IHA7CkBAIC0xOTI3LDYgKzE5MzAsNyBAQCBkaGNwNl9jaGVja3N0
 YXR1c29rKGNvbnN0IHN0cnVjdCBpbnRlcmZhY2UgKmlmcCwKIAkJZmFyZyA9IG07CiAJaWYg
 KChvcHQgPSBmKGZhcmcsIGxlbiwgRDZfT1BUSU9OX1NUQVRVU19DT0RFLCAmb3B0X2xlbikp
 ID09IE5VTEwpIHsKIAkJLy9sb2dkZWJ1Z3goIiVzOiBubyBzdGF0dXMiLCBpZnAtPm5hbWUp
 OworCQlzdGF0ZS0+bGVycm9yID0gMDsKIAkJcmV0dXJuIDA7CiAJfQogCkBAIC0xOTM2LDgg
 KzE5NDAsMTAgQEAgZGhjcDZfY2hlY2tzdGF0dXNvayhjb25zdCBzdHJ1Y3QgaW50ZXJmYWNl
 ICppZnAsCiAJfQogCW1lbWNweSgmY29kZSwgb3B0LCBzaXplb2YoY29kZSkpOwogCWNvZGUg
 PSBudG9ocyhjb2RlKTsKLQlpZiAoY29kZSA9PSBENl9TVEFUVVNfT0spCisJaWYgKGNvZGUg
 PT0gRDZfU1RBVFVTX09LKSB7CisJCXN0YXRlLT5sZXJyb3IgPSAwOwogCQlyZXR1cm4gMTsK
 Kwl9CiAKIAkvKiBBbnl0aGluZyBhZnRlciB0aGUgY29kZSBpcyBhIG1lc3NhZ2UuICovCiAJ
 b3B0ICs9IHNpemVvZihjb2RlKTsKQEAgLTE5NjAsOCArMTk2NiwxMyBAQCBkaGNwNl9jaGVj
 a3N0YXR1c29rKGNvbnN0IHN0cnVjdCBpbnRlcmZhY2UgKmlmcCwKIAkJc3RhdHVzID0gc2J1
 ZjsKIAl9CiAKLQlsb2dlcnJ4KCIlczogREhDUHY2IFJFUExZOiAlcyIsIGlmcC0+bmFtZSwg
 c3RhdHVzKTsKKwlpZiAoc3RhdGUtPmxlcnJvciA9PSBjb2RlIHx8IHN0YXRlLT5zdGF0ZSA9
 PSBESDZTX0lOSVQpCisJCWxvZ2Z1bmMgPSBsb2dkZWJ1Z3g7CisJZWxzZQorCQlsb2dmdW5j
 ID0gbG9nZXJyeDsKKwlsb2dmdW5jKCIlczogREhDUHY2IFJFUExZOiAlcyIsIGlmcC0+bmFt
 ZSwgc3RhdHVzKTsKIAlmcmVlKHNidWYpOworCXN0YXRlLT5sZXJyb3IgPSBjb2RlOwogCXJl
 dHVybiAtMTsKIH0KIApAQCAtMzc5NCw2ICszODA1LDcgQEAgZGhjcDZfc3RhcnQoc3RydWN0
 IGludGVyZmFjZSAqaWZwLCBlbnVtIERINlMgaW5pdF9zdGF0ZSkKIAogZ29nb2dvOgogCXN0
 YXRlLT5zdGF0ZSA9IGluaXRfc3RhdGU7CisJc3RhdGUtPmxlcnJvciA9IDA7CiAJZGhjcF9z
 ZXRfbGVhc2VmaWxlKHN0YXRlLT5sZWFzZWZpbGUsIHNpemVvZihzdGF0ZS0+bGVhc2VmaWxl
 KSwKIAkgICAgQUZfSU5FVDYsIGlmcCk7CiAJaWYgKGlwdjZfbGlua2xvY2FsKGlmcCkgPT0g
 TlVMTCkgewpAQCAtMzgxMywxOCArMzgyNSwyMCBAQCBkaGNwNl9yZWJvb3Qoc3RydWN0IGlu
 dGVyZmFjZSAqaWZwKQogCXN0cnVjdCBkaGNwNl9zdGF0ZSAqc3RhdGU7CiAKIAlzdGF0ZSA9
 IEQ2X1NUQVRFKGlmcCk7Ci0JaWYgKHN0YXRlKSB7Ci0JCXN3aXRjaCAoc3RhdGUtPnN0YXRl
 KSB7Ci0JCWNhc2UgREg2U19CT1VORDoKLQkJCWRoY3A2X3N0YXJ0cmViaW5kKGlmcCk7Ci0J
 CQlicmVhazsKLQkJY2FzZSBESDZTX0lORk9STUVEOgotCQkJZGhjcDZfc3RhcnRpbmZvcm0o
 aWZwKTsKLQkJCWJyZWFrOwotCQlkZWZhdWx0OgotCQkJZGhjcDZfc3RhcnRkaXNjb3Zlcihp
 ZnApOwotCQkJYnJlYWs7Ci0JCX0KKwlpZiAoc3RhdGUgPT0gTlVMTCkKKwkJcmV0dXJuOwor
 CisJc3RhdGUtPmxlcnJvciA9IDA7CisJc3dpdGNoIChzdGF0ZS0+c3RhdGUpIHsKKwljYXNl
 IERINlNfQk9VTkQ6CisJCWRoY3A2X3N0YXJ0cmViaW5kKGlmcCk7CisJCWJyZWFrOworCWNh
 c2UgREg2U19JTkZPUk1FRDoKKwkJZGhjcDZfc3RhcnRpbmZvcm0oaWZwKTsKKwkJYnJlYWs7
 CisJZGVmYXVsdDoKKwkJZGhjcDZfc3RhcnRkaXNjb3ZlcihpZnApOworCQlicmVhazsKIAl9
 CiB9CiAKZGlmZiAtLWdpdCBhL3NyYy9kaGNwNi5oIGIvc3JjL2RoY3A2LmgKaW5kZXggZTFh
 MGEzNzQuLmE2NzA1NjZkIDEwMDY0NAotLS0gYS9zcmMvZGhjcDYuaAorKysgYi9zcmMvZGhj
 cDYuaApAQCAtMjA2LDcgKzIwNiw3IEBAIHN0cnVjdCBkaGNwNl9zdGF0ZSB7CiAJLyogVGhl
 ICszIGlzIGZvciB0aGUgcG9zc2libGUgLnBkIGV4dGVuc2lvbiBmb3IgcHJlZml4IGRlbGVn
 YXRpb24gKi8KIAljaGFyIGxlYXNlZmlsZVtzaXplb2YoTEVBU0VGSUxFNikgKyBJRl9OQU1F
 U0laRSArIChJRl9TU0lETEVOICogNCkgKzNdOwogCWNvbnN0IGNoYXIgKnJlYXNvbjsKLQor
 CXVpbnQxNl90IGxlcnJvcjsgLyogTGFzdCBlcnJvciByZWNlaXZlZCBmcm9tIERIQ1B2NiBy
 ZXBseS4gKi8KIAlzdHJ1Y3QgYXV0aHN0YXRlIGF1dGg7CiB9OwogCg==
 --------------3F76325E9495F45A3CC31F97--