Re: lib/54017: jemalloc deadlock?

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

The following reply was made to PR lib/54017; it has been noted by GNATS.

From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
To: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%NetBSD.org@localhost>,
 Christos Zoulas <christos%astron.com@localhost>
Cc: 
Subject: Re: lib/54017: jemalloc deadlock?
Date: Fri, 15 Mar 2019 04:24:31 +0900

 I found it! pkgsrc/wip/emacs-git successfully builds if reverting
 our local hack for sshd:
 
 ----
 Index: external/bsd/jemalloc/dist/src/jemalloc.c
 ===================================================================
 RCS file: /home/netbsd/src/external/bsd/jemalloc/dist/src/jemalloc.c,v
 retrieving revision 1.6
 diff -p -u -r1.6 jemalloc.c
 --- external/bsd/jemalloc/dist/src/jemalloc.c	12 Mar 2019 15:13:25 -0000	1.6
 +++ external/bsd/jemalloc/dist/src/jemalloc.c	14 Mar 2019 18:52:25 -0000
 @@ -2339,7 +2339,7 @@ je_realloc(void *ptr, size_t size) {
   				tcache = NULL;
   			}
   			ifree(tsd, ptr, tcache, true);
 -#ifdef notyet
 +#if 1
   			/*
   			 * sshd depends on realloc(p, 0) returning non-NULL
   			 * disable for compatibility for now
 ----
 
 sshd and ssh work fine as far as I can see (usual login and X11
 forwarding). Do we really need that?
 
 Thanks,
 rin