Re: kern/53991: X does not work on amd64/7.2 after pgoyette-compat

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR kern/53991; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: isaki%pastel-flower.jp@localhost
Subject: Re: kern/53991: X does not work on amd64/7.2 after pgoyette-compat
Date: Wed, 20 Feb 2019 09:53:15 +0800 (PST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --0-1322193257-1550627595=:9370
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 On Tue, 19 Feb 2019, Tetsuya Isaki wrote:
 
 > Thank you for quick response.
 > I found the problem while I try to use ktruss.
 > 
 > uim-xim (from pkgsrc/inputmethod/uim) cause a panic even without X.
 > So I was able to get a backtrace.  Does this help you?
 > By the way, my subject was not correct, sorry :(
 > 
 > % uim-xim
 >  :
 >  1539 1 uim-xim open("/usr/pkg/lib/nss_nis.so.0", 0, ...) Err#2 ENOENT
 >  1539 1 uim-xim open("/usr/lib/nss_nis.so.0", 0, 0x6e) Err#2 ENOENT
 >  1539 1 uim-xim __sigprocmask14(0x3, 0x7f7fffabb940, 0) = 0
 >  1539 1 uim-xim __lwp_self() = 1
 >  1539 1 uim-xim __sigprocmask14(0x1, 0x7f7fffabb900, 0x7f7fffabb940) = 0
 >  1539 1 uim-xim open("/usr/X11R7/lib/nss_files.so.0", 0, 0x6e) Err#2 ENOENT
 >  1539 1 uim-xim open("/usr/pkg/lib/nss_files.so.0", 0, 0x70) Err#2 ENOENT
 >  1539 1 uim-xim open("/usr/lib/nss_files.so.0", 0, 0x6e) Err#2 ENOENT
 >  1539 1 uim-xim __sigprocmask14(0x3, 0x7f7fffabb940, 0) = 0
 >  1539 1 uim-xim __lwp_self() = 1
 >  1539 1 uim-xim __sigprocmask14(0x1, 0x7f7fffabb900, 0x7f7fffabb940) = 0
 >  1539 1 uim-xim open("/usr/X11R7/lib/nss_dns.so.0", 0, 0x6e) Err#2 ENOENT
 > uvm_fault(0xffff803279bfe170, 0x0, 1) -> e
 > fatal page fault in supervisor mode
 > trap type 6 code 0 rip 0xffffffff80a36ebd cs 0x8 rflags 0x10246 cr2 0x1
 > ilevel 0 rsp 0xffff87002e6a3e80
 > curlwp 0xffff8032a5ef2200 pid 1539.1 lowest kstack 0xffff87002e6a02c0
 > kernel: page fault trap, code=0
 > Stopped in pid 1539.1 (uim-xim) at netbsd:uipc_ctloutput+0x6e: cmpb $0,0(%rax)
 > db{0}> bt
 > uipc_ctloutput() at netbsd:uipc_ctloutput+0x6e
 > sosetopt() at netbsd:sosetopt+0x7d
 > sys_setsockopt() at netbsd:sys_setsockopt+0x8e
 > syscall() at netbsd:syscall+0x2d8
 > --- syscall (number 105) ---
 > 79da516d1c4a:
 > db{0}>
 
 To fix the panic, please try the following patch (also provided as an
 attachment, since sometimes my MUA screws up tabs!)  If that works,
 please see if the original problem ("X won't start") is also fixed.
 
 Thanks!
 
 
 Index: uipc_usrreq.c
 ===================================================================
 RCS file: /cvsroot/src/sys/kern/uipc_usrreq.c,v
 retrieving revision 1.190
 diff -u -p -r1.190 uipc_usrreq.c
 --- uipc_usrreq.c	4 Feb 2019 10:11:34 -0000	1.190
 +++ uipc_usrreq.c	19 Feb 2019 21:58:08 -0000
 @@ -126,6 +126,7 @@ __KERNEL_RCSID(0, "$NetBSD: uipc_usrreq.
   #include <sys/compat_stub.h>
 
   #include <compat/sys/socket.h>
 +#include <compat/net/route_70.h>
 
   /*
    * Unix communications domain.
 @@ -208,7 +209,7 @@ struct mbuf * stub_compat_70_unp_addsock
   	return control;
   }
 
 -bool *compat70_ocreds_valid = false;
 +bool compat70_ocreds_valid = false;
 
   /*
    * Initialize Unix protocols.
 @@ -610,7 +611,7 @@ uipc_ctloutput(int op, struct socket *so
   	case PRCO_SETOPT:
   		switch (sopt->sopt_name) {
   		case LOCAL_OCREDS:
 -			if (!*compat70_ocreds_valid)  {
 +			if (!compat70_ocreds_valid)  {
   				error = ENOPROTOOPT;
   				break;
   			}
 @@ -664,7 +665,7 @@ uipc_ctloutput(int op, struct socket *so
   			error = sockopt_setint(sopt, optval);
   			break;
   		case LOCAL_OCREDS:
 -			if (*compat70_ocreds_valid) {
 +			if (compat70_ocreds_valid) {
   				optval = OPTBIT(UNP_OWANTCRED);
   				error = sockopt_setint(sopt, optval);
   				break;
 
 
 
 +------------------+--------------------------+----------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
 +------------------+--------------------------+----------------------------+
 --0-1322193257-1550627595=:9370
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=uipc_usrreq.c.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <Pine.NEB.4.64.1902200953150.9370%speedy.whooppee.com@localhost>
 Content-Description: 
 Content-Disposition: attachment; filename=uipc_usrreq.c.diff
 
 SW5kZXg6IHVpcGNfdXNycmVxLmMNCj09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
 ClJDUyBmaWxlOiAvY3Zzcm9vdC9zcmMvc3lzL2tlcm4vdWlwY191c3JyZXEu
 Yyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTkwDQpkaWZmIC11IC1wIC1y
 MS4xOTAgdWlwY191c3JyZXEuYw0KLS0tIHVpcGNfdXNycmVxLmMJNCBGZWIg
 MjAxOSAxMDoxMTozNCAtMDAwMAkxLjE5MA0KKysrIHVpcGNfdXNycmVxLmMJ
 MTkgRmViIDIwMTkgMjE6NTg6MDggLTAwMDANCkBAIC0xMjYsNiArMTI2LDcg
 QEAgX19LRVJORUxfUkNTSUQoMCwgIiROZXRCU0Q6IHVpcGNfdXNycmVxLg0K
 ICNpbmNsdWRlIDxzeXMvY29tcGF0X3N0dWIuaD4NCiANCiAjaW5jbHVkZSA8
 Y29tcGF0L3N5cy9zb2NrZXQuaD4NCisjaW5jbHVkZSA8Y29tcGF0L25ldC9y
 b3V0ZV83MC5oPg0KIA0KIC8qDQogICogVW5peCBjb21tdW5pY2F0aW9ucyBk
 b21haW4uDQpAQCAtMjA4LDcgKzIwOSw3IEBAIHN0cnVjdCBtYnVmICogc3R1
 Yl9jb21wYXRfNzBfdW5wX2FkZHNvY2sNCiAJcmV0dXJuIGNvbnRyb2w7DQog
 fQ0KIA0KLWJvb2wgKmNvbXBhdDcwX29jcmVkc192YWxpZCA9IGZhbHNlOw0K
 K2Jvb2wgY29tcGF0NzBfb2NyZWRzX3ZhbGlkID0gZmFsc2U7DQogDQogLyoN
 CiAgKiBJbml0aWFsaXplIFVuaXggcHJvdG9jb2xzLg0KQEAgLTYxMCw3ICs2
 MTEsNyBAQCB1aXBjX2N0bG91dHB1dChpbnQgb3AsIHN0cnVjdCBzb2NrZXQg
 KnNvDQogCWNhc2UgUFJDT19TRVRPUFQ6DQogCQlzd2l0Y2ggKHNvcHQtPnNv
 cHRfbmFtZSkgew0KIAkJY2FzZSBMT0NBTF9PQ1JFRFM6DQotCQkJaWYgKCEq
 Y29tcGF0NzBfb2NyZWRzX3ZhbGlkKSAgew0KKwkJCWlmICghY29tcGF0NzBf
 b2NyZWRzX3ZhbGlkKSAgew0KIAkJCQllcnJvciA9IEVOT1BST1RPT1BUOw0K
 IAkJCQlicmVhazsNCiAJCQl9DQpAQCAtNjY0LDcgKzY2NSw3IEBAIHVpcGNf
 Y3Rsb3V0cHV0KGludCBvcCwgc3RydWN0IHNvY2tldCAqc28NCiAJCQllcnJv
 ciA9IHNvY2tvcHRfc2V0aW50KHNvcHQsIG9wdHZhbCk7DQogCQkJYnJlYWs7
 DQogCQljYXNlIExPQ0FMX09DUkVEUzoNCi0JCQlpZiAoKmNvbXBhdDcwX29j
 cmVkc192YWxpZCkgew0KKwkJCWlmIChjb21wYXQ3MF9vY3JlZHNfdmFsaWQp
 IHsNCiAJCQkJb3B0dmFsID0gT1BUQklUKFVOUF9PV0FOVENSRUQpOw0KIAkJ
 CQllcnJvciA9IHNvY2tvcHRfc2V0aW50KHNvcHQsIG9wdHZhbCk7DQogCQkJ
 CWJyZWFrOw0K
 
 --0-1322193257-1550627595=:9370--