Re: PR/53904 CVS commit: src/lib/libc/gen

[christos%zoulas.com@localhost (Christos Zoulas)]

On Jan 25,  5:15pm, dholland-bugs%netbsd.org@localhost (David Holland) wrote:
-- Subject: Re: PR/53904 CVS commit: src/lib/libc/gen

| The following reply was made to PR lib/53904; it has been noted by GNATS.
| 
| From: David Holland <dholland-bugs%netbsd.org@localhost>
| To: gnats-bugs%NetBSD.org@localhost
| Cc: 
| Subject: Re: PR/53904 CVS commit: src/lib/libc/gen
| Date: Fri, 25 Jan 2019 17:11:04 +0000
| 
|  On Thu, Jan 24, 2019 at 08:45:01PM +0000, Joerg Sonnenberger wrote:
|   >  [popen] should be using close-on-exec
|  
|  Are you sure that's allowed? I know it's dodgy but I wouldn't be
|  super-surprised to find someone using popen in conjunction with
|  fork/exec.

The issues are orthogonal. pclose(3) needs to have access to the child
process info to wait for it. Close-on-exec has nothing to do with it.
In fact you can select the close-on-exec behavior by adding "e" to the
"type" argument as mentioned in the man page.

christos