kern/53892: i915drmkms requires firmload

[dholland%eecs.harvard.edu@localhost]

>Number:         53892
>Category:       kern
>Synopsis:       i915drmkms requires firmload
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 19 07:25:00 +0000 2019
>Originator:     David Holland
>Release:        NetBSD 8.99.27 (20190119)
>Organization:
>Environment:
System: NetBSD amberdon 8.99.14 NetBSD 8.99.14 (AMBERDON) #22: Wed Mar 28 06:15:53 EDT 2018 root@amberdon:/usr/src/sys/arch/amd64/compile/AMBERDON amd64
Architecture: x86_64
Machine: amd64
>Description:

Building a kernel i915drmkms and enough other things turned off fails
to link with symbols from firmload.c like firmware_malloc.

>How-To-Repeat:

vi; config; make

>Fix:

Index: files.i915drmkms
===================================================================
RCS file: /cvsroot/src/sys/external/bsd/drm2/i915drm/files.i915drmkms,v
retrieving revision 1.33
diff -u -r1.33 files.i915drmkms
--- files.i915drmkms	21 Sep 2018 11:27:13 -0000	1.33
+++ files.i915drmkms	19 Jan 2019 07:15:44 -0000
@@ -3,7 +3,7 @@
 version	20180827
 
 define	intelfbbus	{ }
-device	i915drmkms: drmkms, drmkms_pci, intelfbbus, agp_i810
+device	i915drmkms: drmkms, drmkms_pci, intelfbbus, agp_i810, firmload
 attach	i915drmkms at pci
 
 device	intelfb: intelfbbus, drmfb, drmfb_pci, wsemuldisplaydev