Re: lib/53682

[Nikhil Benesch <nikhil.benesch%gmail.com@localhost>]

The following reply was made to PR lib/53682; it has been noted by GNATS.

From: Nikhil Benesch <nikhil.benesch%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: christos%zoulas.com@localhost, jordan%cockroachlabs.com@localhost
Subject: Re: lib/53682
Date: Wed, 21 Nov 2018 10:57:19 -0500

 >  As I mentioned before there will be no 'display' problems
 
 Sorry, I'm struggling to stay in the loop on this PR since I'm not
 subscribed to gnats-bugs. If you've previously rendered feedback on
 this patch or the issue (i.e., before the mail that I've quoted above),
 I'm afraid I can't see it.
 
 > (well you removed the loop too, so I don't know what happens if it needs
 > to move more than one line)
 
 If you look more closely at the patch, you'll see that the remaining code
 either issues a T_DO to move down multiple lines at once, or uses a for
 loop to issue the requisite number of individual newlines. So it works
 just fine if it needs to move more than one line.
 
 > You just removed the code that does <space><backspace> in the
 > automatic margins case to move the cursor to the next line when it is
 > at the right margin.
 
 Is that what the code is intended to do? AFAICT you wrote and/or
 imported this code into NetBSD, so you are the right person to ask. :)
 
 The code I removed *unconditionally* issues
 
     <move-to-right-margin><space><backspace>
 
 regardless of whether the cursor is already at the right margin. If it
 was only supposed to do that if the cursor was already at the right
 margin, perhaps fixing that will also fix the problem described in this
 PR.
 
 > If you try to cut and paste a multi-line string from a shell that
 > uses libedit using mouse selection, now it will break into multiple
 > lines, where before it would work just fine.
 
 The behavior you describe is the behavior I see both with and without
 my patch. Are you speculating, are do you see incorrect behavior in
 your terminal emulator with my patch? If the latter, I'd be happy to
 investigate further if you tell me what terminal emulator you use.