Re: lib/53682

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/53682; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, lib-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
	jordan%cockroachlabs.com@localhost
Cc: 
Subject: Re: lib/53682
Date: Wed, 21 Nov 2018 03:29:31 -0500

 On Nov 21,  4:15am, nikhil.benesch%gmail.com@localhost (Nikhil Benesch) wrote:
 -- Subject: Re: lib/53682
 
 |  Apologies. It appears my email client is swallowing indentation. Here's
 |  a link to the patch instead.
 |  
 |  https://gist.githubusercontent.com/benesch/48ac40e76179ec7f71c58c6360f9c391/raw/150d515f7254256766869937923260fe0fd68e7a/term-no-space.patch.
 |  
 |  I've now tested this patch on macOS Terminal app 2.7.4 (388.1.2), GNOME
 |  terminal 3.18.3, and XTerm 322 without observing any problems.
 |  
 
 As I mentioned before there will be no 'display' problems (well
 you removed the loop too, so I don't know what happens if it needs
 to move more than one line). You just removed the code that does
 <space><backspace> in the automatic margins case to move the cursor
 to the next line when it is at the right margin. This code is there
 to avoid putting a newline into the character buffer. If you try
 to cut and paste a multi-line string from a shell that uses libedit
 using mouse selection, now it will break into multiple lines, where
 before it would work just fine.
 
 christos