Re: PR/53524 CVS commit: src/sys/dev/ic

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

The following reply was made to PR kern/53524; it has been noted by GNATS.

From: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost, jdolecek%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost, martin%NetBSD.org@localhost
Cc: 
Subject: Re: PR/53524 CVS commit: src/sys/dev/ic
Date: Tue, 20 Nov 2018 21:33:14 +0000

 On 20/11/2018 20:40, Markus Kilbinger wrote:
 > The following reply was made to PR kern/53524; it has been noted by GNATS.
 > 
 > From: Markus Kilbinger <mk%kilbi.de@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: martin%netbsd.org@localhost
 > Subject: Re: PR/53524 CVS commit: src/sys/dev/ic
 > Date: Tue, 20 Nov 2018 20:23:21 +0100
 > 
 >   >    > To generate a diff of this commit:
 >    >    >  cvs rdiff -u -r1.69 -r1.70 src/sys/dev/ic/ahcisata_core.c
 >    >
 >    >  This change breaks booting on my 'bananapro' (evbarm/)earmv7hf; stuck
 >    >  before normal 'Copyright ...' message) which has a sata connector, but
 >    >  no device is connected in my case.
 >   
 >    > Are you *sure* it is this change? The code in question only runs
 >   much later...
 >   
 >   Yes, I just re-checked: Just reverting to -r1.69 makes my bananapro
 >   boot again and re-reverting to -r1.70 makes it stuck again.
 
 Can you compare kernel sizes with and without the change? I agree with 
 Martin that this code runs much later.
 
 Also, does the problem occur with VERBOSE_INIT_ARM/EARLYCONS defined?	
 
 >   
 >    > Also: which kernel are you booting? I have seen random hangs as you describe
 >    > with the GENERIC kernel, but never with SUNXI.
 >   
 >   It's the normal GENERIC kernel (le) which boots fine on my cubietruck
 >   with a sata drive attached.
 >   
 >   (BTW: I switched from SUNXI to GENERIC kernel some time ago, because
 >   the SUNXI kernel no longer worked properly).
 
 How did it stop working?
 
 >   
 >    Are you by chance runnning a big endian GENERIC kernel?
 >   
 >   No.
 >   
 >   Markus.
 >   
 > 
 
 Thanks,
 Nck