Re: PR/53605 CVS commit: src/sys/dev

[MB <code%boerschig.net@localhost>]

The following reply was made to PR kern/53605; it has been noted by GNATS.

From: MB <code%boerschig.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/53605 CVS commit: src/sys/dev
Date: Sat, 17 Nov 2018 08:46:58 +0100

 After applying this fix the keyboard still doesn't work (key presses
 show up as bad repid 5 ):
 
 [ 640.8601947] uhidev0: HOLDCHIP (0x4d9) USB Gaming Keyboard (0xa0f8),
 rev 1.10/2.00, addr 5, iclass 3/1
 [ 640.8601947] ukbd0 at uhidev0: 8 Variable keys, 6 Array codes
 [ 641.2703372] wskbd0 at ukbd0: console keyboard, using wsdisplay0
 [ 641.2703372] uhidev1 at uhub1 port 2 configuration 1 interface 1
 [ 641.2703372] uhidev1: HOLDCHIP (0x4d9) USB Gaming Keyboard (0xa0f8),
 rev 1.10/2.00, addr 5, iclass 3/0
 [ 641.2703372] uhidev1: 4 report ids
 [ 641.2703372] uhid0 at uhidev1 reportid 1: input=1, output=0, feature=0
 [ 641.2703372] uhid1 at uhidev1 reportid 2: input=3, output=0, feature=0
 [ 641.2703372] ukbd1 at uhidev1 reportid 4: 232 Variable keys, 0 Array codes
 [ 641.6804798] wskbd1 at ukbd1 mux 1
 [ 641.6804798] wskbd1: connecting to wsdisplay0
 [ 641.6804798] uhidev2 at uhub1 port 2 configuration 1 interface 2
 [ 641.6804798] uhidev2: HOLDCHIP (0x4d9) USB Gaming Keyboard (0xa0f8),
 rev 1.10/2.00, addr 5, iclass 3/0
 [ 641.6804798] uhid2 at uhidev2: input=32, output=32, feature=8
 [ 643.1709979] uhidev_intr: bad repid 5
 [ 643.2910395] uhidev_intr: bad repid 5
 
 If there is something I could test or if you need more debug logs please
 let me know.
 
 OTOH, it would be nice if someone could add the usb_quirk for the
 keyboard to work in boot protocol mode I proposed earlier.
 
 
 On 16.11.18 00:05, Jonathan A. Kollasch wrote:
 > The following reply was made to PR kern/53605; it has been noted by GNATS.
 > 
 > From: "Jonathan A. Kollasch" <jakllsch%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/53605 CVS commit: src/sys/dev
 > Date: Thu, 15 Nov 2018 23:01:46 +0000
 > 
 >  Module Name:	src
 >  Committed By:	jakllsch
 >  Date:		Thu Nov 15 23:01:46 UTC 2018
 >  
 >  Modified Files:
 >  	src/sys/dev/bluetooth: bthidev.c
 >  	src/sys/dev/hid: hid.c hid.h
 >  	src/sys/dev/i2c: ihidev.c
 >  	src/sys/dev/usb: uhidev.c
 >  
 >  Log Message:
 >  Correctly handle signed/unsigned quantities in kernel HID parser.
 >  
 >  Should fix PR kern/53605.
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.30 -r1.31 src/sys/dev/bluetooth/bthidev.c
 >  cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hid/hid.c src/sys/dev/hid/hid.h
 >  cvs rdiff -u -r1.5 -r1.6 src/sys/dev/i2c/ihidev.c
 >  cvs rdiff -u -r1.73 -r1.74 src/sys/dev/usb/uhidev.c
 >  
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >  
 >