Re: bin/53709: cannot build evbmips64-eb tools with gcc using clang

[coypu%sdf.org@localhost]

The following reply was made to PR bin/53709; it has been noted by GNATS.

From: coypu%sdf.org@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/53709: cannot build evbmips64-eb tools with gcc using clang
Date: Sun, 11 Nov 2018 21:26:15 +0000

 joerg is a veteran of GCC bullshit and notes the getc macro originates
 in GCC's system.h, so e.g. this works:
 
 Index: dist/gcc/system.h
 ===================================================================
 RCS file: /cvsroot/src/external/gpl3/gcc.old/dist/gcc/system.h,v
 retrieving revision 1.7
 diff -U 10 -r1.7 system.h
 --- dist/gcc/system.h	2 Aug 2018 00:02:49 -0000	1.7
 +++ dist/gcc/system.h	11 Nov 2018 21:25:49 -0000
 @@ -75,21 +75,21 @@
     I/O bound conditions (such as -g -O0 on very large source files).
  
     HAVE_DECL_PUTC_UNLOCKED actually indicates whether or not the stdio
     code is multi-thread safe by default.  If it is set to 0, then do
     not worry about using the _unlocked functions.
  
     fputs_unlocked, fwrite_unlocked, and fprintf_unlocked are
     extensions and need to be prototyped by hand (since we do not
     define _GNU_SOURCE).  */
  
 -#if defined HAVE_DECL_PUTC_UNLOCKED && HAVE_DECL_PUTC_UNLOCKED
 +#if defined HAVE_DECL_PUTC_UNLOCKED && HAVE_DECL_PUTC_UNLOCKED && !defined(__cplusplus)
  
  # ifdef HAVE_PUTC_UNLOCKED
  #  undef putc
  #  define putc(C, Stream) putc_unlocked (C, Stream)
  # endif
  # ifdef HAVE_PUTCHAR_UNLOCKED
  #  undef putchar
  #  define putchar(C) putchar_unlocked (C)
  # endif
  # ifdef HAVE_GETC_UNLOCKED