kern/53720: TOOL_DTC does not have a fallback if USE_TOOLS isn't set

[daniel+netbsd%loffgren.org@localhost]

>Number:         53720
>Category:       kern
>Synopsis:       TOOL_DTC does not have a fallback if USE_TOOLS isn't set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 11 02:10:00 +0000 2018
>Originator:     Daniel Loffgren
>Release:        NetBSD 8.99.25, Current as of ~Nov 8 2018
>Organization:
>Environment:
System: NetBSD pinebook 8.99.25 NetBSD 8.99.25 (PINEBOOK) #0: Fri Nov 9 18:10:13 PST 2018 kojiro@pinebook:/usr/src/sys/arch/evbarm/compile/PINEBOOK evbarm
Architecture: aarch64
Machine: evbarm
>Description:
Building an evbarm kernel using simply "make" fails due to TOOL_DTC not being defined.
TOOL_DTC is defined in src/share/mk/bsd.own.mk, when USE_TOOLS is set, but not in the body of the else with the rest of the default ones.
This can be worked around by doing "make TOOL_DTC=dtc", but that shouldn't be required.
>How-To-Repeat:
>From a fresh source checkout, attempt to build an evbarm kernel using something along the lines of:
	cd /usr/src/sys/arch/evbarm/conf/
	config GENERIC64
	cd ../compile/GENERIC64
	make depend
	make

>Fix:
Index: bsd.own.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.own.mk,v
retrieving revision 1.1078
diff -u -r1.1078 bsd.own.mk
--- bsd.own.mk	6 Oct 2018 18:52:59 -0000	1.1078
+++ bsd.own.mk	11 Nov 2018 01:12:32 -0000
@@ -485,6 +485,7 @@
 TOOL_CTFMERGE=		ctfmerge
 TOOL_CVSLATEST=		cvslatest
 TOOL_DB=		db
+TOOL_DTC=		dtc
 TOOL_DISKLABEL=		disklabel
 TOOL_EQN=		eqn
 TOOL_FDISK=		fdisk