Re: kern/53714: Panic during recovery from IDE disk error

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/53714; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/53714: Panic during recovery from IDE disk error
Date: Sat, 10 Nov 2018 12:53:37 -0000 (UTC)

 gson%gson.org@localhost (Andreas Gustafsson) writes:
 
 >[ 1316.8732393] ata_thread_run(c2207108,0,200,ff,c2207108,c2207000,c2275d08,0,cdcb5eb8,c01ac108) at netbsd:ata_thread_run+0x1e
 >[ 1316.9132490] ata_downgrade_mode(c2272008,0,cdcb5f00,c01a9c72,c2272008,0,50,0,10,cdcb5edc) at netbsd:ata_downgrade_mode+0x16b
 
 ata_downgrade_mode calls ata_thread_run without taking the channel lock.
 
 Maybe this:
 
 Index: ata.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ata/ata.c,v
 retrieving revision 1.145
 diff -u -r1.145 ata.c
 --- ata.c       24 Oct 2018 20:25:52 -0000      1.145
 +++ ata.c       10 Nov 2018 12:53:20 -0000
 @@ -1809,7 +1809,9 @@
         (*atac->atac_set_modes)(chp);
         ata_print_modes(chp);
         /* reset the channel, which will schedule all drives for setup */
 +       ata_channel_lock(chp);
         ata_thread_run(chp, flags, ATACH_TH_RESET, ATACH_NODRIVE);
 +       ata_channel_unlock(chp);
         return 1;
  }
  #endif /* NATA_DMA */
 
 -- 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."