NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/53666: tcpdump for i386 does not work with COMPAT_NETBSD32 on amd64



The following reply was made to PR kern/53666; it has been noted by GNATS.

From: Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>
To: matthew green <mrg%eterna.com.au@localhost>, gnats-bugs%NetBSD.org@localhost,
 Paul Goyette <paul%whooppee.com@localhost>
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/53666: tcpdump for i386 does not work with COMPAT_NETBSD32
 on amd64
Date: Fri, 12 Oct 2018 15:54:40 +0900

 On 2018/10/12 15:04, matthew green wrote:
 > i also notice that BIOCGRTIMEOUT needs handling too.
 
 Oops, we also need BIOC[GS]ORTIMEOUT when COMPAT_50:
 
    https://nxr.netbsd.org/xref/src/sys/net/bpf.h#132
 
 Is it OK to have #ifdef COMPAT_50 (or equivalently,
 #ifdef BIOC[GS]ORTIMEOUT) in netbsd32_ioctl.c?
 
 Anyway, I would like to decide the way before proceeding further.
 
 (1) add unused "u_long cmd" argument to all netbsd32_{to,from}_foo()
 functions in netbsd32_conv.h, and move netbsd32_{to,from}_foo() in
 netbsd32_ioctl.c to netbsd32_conv.h
 
 or
 
 (2) leave preprocessor mess as is
 
 or
 
 (3) other
 
 Paul, how do you think?
 


Home | Main Index | Thread Index | Old Index