Re: PR/30978 CVS commit: src/lib/libcurses

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

The following reply was made to PR lib/30978; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/30978 CVS commit: src/lib/libcurses
Date: Thu, 11 Oct 2018 23:58:27 +0300

 On Wed, Oct 10, 2018 at 09:45:00 +0000, Roy Marples wrote:
 
 >  Module Name:	src
 >  Committed By:	roy
 >  Date:		Wed Oct 10 09:40:11 UTC 2018
 >  
 >  Modified Files:
 >  	src/lib/libcurses: newwin.c refresh.c
 >  
 >  Log Message:
 >  curses: test terminal capabilities for drawing in the bottom right corner
 >  
 >  If auto margins are present, we need to turn them off or enter
 >  an insert mode to "push" the character we want into the corner.
 >  If pushing a wide character of greater than one cell, we need something
 >  more than ich1, othewise the bottom right corner will remain blank.
 >  
 >  Follow on fix for PR# 30978.
 >  
 >  OK jdc@
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.53 -r1.54 src/lib/libcurses/newwin.c
 >  cvs rdiff -u -r1.89 -r1.90 src/lib/libcurses/refresh.c
 
 I've tested this on our wsemul_sun and on solaris console and it
 helps.
 
 But not completely.  The corner case it doesn't handle is alt-charset.
 
     dailog --no-shadow --msgbox "hello world" $(stty size)
 
 On xterm-color the characters in the last and last-but-one columns are
 not in alt-charset.
 
 In ascii art approximation I get:
 
        |
     --qj
 
 or, with msgbox width that is one less than the terminal size:
 
      |
     -j
 
 That 'j' also has different colors in this latter case.
 
 -uwe