Re: lib/53653: Curses doesn't always show line drawing characters correctly on wsvt25

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/53653; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, lib-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, uwe%NetBSD.org@localhost
Cc: 
Subject: Re: lib/53653: Curses doesn't always show line drawing characters correctly on wsvt25
Date: Wed, 10 Oct 2018 16:30:32 -0400

 On Oct 10,  7:50pm, jdc%coris.org.uk@localhost (Julian Coleman) wrote:
 -- Subject: Re: lib/53653: Curses doesn't always show line drawing characters
 
 |  Hi,
 |  
 |  Looking at the output with tracing on, I see for the vt220 case:
 |  
 |    1539197247.063514: does_ctrl_o: Testing ^[[m^[(B for ^[(B$<4>
 |  
 |  when we check to see if turning off all attributes also turns off ACS.
 |  However, the terminfo entry for vt220 doesn't contain any delay for sgr0,
 |  whilst it does for rmacs:
 |  
 |    rmacs=\E(B$<4>, sgr0=\E[m\E(B
 |  
 |  so we think that sending sgr0 (i.e. when unsetting bold) didn't unset ACS
 |  mode, and thus we don't set ACS mode again.
 |  
 |  This might be a bug in the terminfo entry and it should really have a delay
 |  in both.  However, stripping the trailing delay from the end of rmacs when
 |  we check is probably a more sensible solution, so the appended patch does
 |  that.
 |  
 
 If trailing delays are illegal/undesired, then terminfo should warn and
 the entry should be fixed. I don't think that curses should be involved :-)
 
 christos