Re: lib/53653: Curses doesn't always show line drawing characters correctly on wsvt25

[Julian Coleman <jdc%coris.org.uk@localhost>]

The following reply was made to PR lib/53653; it has been noted by GNATS.

From: Julian Coleman <jdc%coris.org.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: lib-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost, uwe%NetBSD.org@localhost
Subject: Re: lib/53653: Curses doesn't always show line drawing characters
 correctly on wsvt25
Date: Mon, 8 Oct 2018 16:20:58 +0200

 Hi,
 
 >  It's not the color, but turning off A_BOLD that seems to confuse it.
 >  The following standalone test case fails with TERM=wsvt25 and
 >  TERM=vt200 (but works with xterm and vt100).
 
 This might be related to the attribute unset logic in refresh.c:
 
   https://nxr.netbsd.org/xref/src/lib/libcurses/refresh.c#1074
 
 where we test colour and other attributes when we disable bold (standout)
 and the logic to set this in setterm.c:
 
   https://nxr.netbsd.org/xref/src/lib/libcurses/setterm.c#223
 
 However, neither of these check ACS, so __unsetattr() is another possibility:
 
   https://nxr.netbsd.org/xref/src/lib/libcurses/refresh.c#1903
 
 For some reason, we think that ACS is still on but we have switched it off.
 However, I'm not sure why we see the difference between xterm/vt100 and
 wsvt25/vt200 here - I guess that we parse the terminfo incorrectly.
 
 Regards,
 
 Julian