toolchain/53544: trouble building lex in tools using build.sh -u

[htodd%twofifty.com@localhost]

>Number:         53544
>Category:       toolchain
>Synopsis:       trouble building lex in tools using build.sh -u
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 23 00:05:00 +0000 2018
>Originator:     htodd%twofifty.com@localhost
>Release:        NetBSD 8.99.24
>Organization:
	
>Environment:
	
	
System: NetBSD mara.i8u.org 8.99.24 NetBSD 8.99.24 (MARA) #3310: Thu Aug 16 23:24:37 PDT 2018 htodd%mara.i8u.org@localhost:/var/shm/amd64/sys/arch/amd64/compile/MARA amd64
Architecture: x86_64
Machine: amd64
>Description:
	
This happens on amd64, too. I'm having trouble doing a build.sh with the -u flag. I have to delete objdirs to have it work right.

dependall ===> lex
--- dependall ---
--- scan.lo ---
#   compile  lex/scan.lo
cc -O  -I/var/shm/tools.sparc64/include/compat -I/usr/src/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -I/usr/src/tools/lex/../../external/bsd/flex/bin/../include -I/usr/src/external/bsd/flex/dist/src -DLOCALEDIR=\"/usr/share/locale\" -I. -I/usr/src/tools/lex/../../external/bsd/flex/bin -DVERSION=\"2.6.3\" -DHAVE_CONFIG_H -I/usr/src/tools/lex/../../external/bsd/flex/bin/../include -I/usr/src/external/bsd/flex/dist/src -DLOCALEDIR=\"/usr/share/locale\" -DM4=\"/var/shm/tools.sparc64/bin/nbm4\" -c -o scan.lo.o    scan.c
In file included from /var/shm/tools.sparc64/include/compat/nbtool_config.h:896:0,
                 from /usr/src/external/bsd/flex/dist/src/flexdef.h:40,
                 from /usr/src/external/bsd/flex/dist/src/initscan.c:1876,
                 from scan.c:1:
/usr/src/tools/compat/compat_defs.h:117:2: error: #error _NETBSD_SOURCE is *not* to be defined.
 #error _NETBSD_SOURCE is *not* to be defined.
  ^~~~~
In file included from /var/shm/tools.sparc64/include/compat/nbtool_config.h:896:0,
                 from /usr/src/external/bsd/flex/dist/src/flexdef.h:40,
                 from /usr/src/external/bsd/flex/dist/src/initscan.c:1876,
                 from scan.c:1:
/usr/src/tools/compat/compat_defs.h:275:8: error: redefinition of 'struct _dirdesc'
 struct _dirdesc {
        ^~~~~~~~
In file included from /usr/src/tools/compat/compat_defs.h:214:0,
                 from /var/shm/tools.sparc64/include/compat/nbtool_config.h:896,
                 from /usr/src/external/bsd/flex/dist/src/flexdef.h:40,
                 from /usr/src/external/bsd/flex/dist/src/initscan.c:1876,
                 from scan.c:1:
/usr/include/dirent.h:50:16: note: originally defined here
 typedef struct _dirdesc DIR;
                ^~~~~~~~
In file included from /var/shm/tools.sparc64/include/compat/nbtool_config.h:896:0,
                 from /usr/src/external/bsd/flex/dist/src/flexdef.h:40,
                 from /usr/src/external/bsd/flex/dist/src/initscan.c:1876,
                 from scan.c:1:
/usr/src/tools/compat/compat_defs.h:286:0: warning: "dirfd" redefined
 #define dirfd(dirp)     (((struct _dirdesc *)dirp)->dd_fd)

In file included from /usr/src/tools/compat/compat_defs.h:214:0,
                 from /var/shm/tools.sparc64/include/compat/nbtool_config.h:896,
                 from /usr/src/external/bsd/flex/dist/src/flexdef.h:40,
                 from /usr/src/external/bsd/flex/dist/src/initscan.c:1876,
                 from scan.c:1:
/usr/include/dirent.h:76:0: note: this is the location of the previous definition
 #define dirfd(dirp) ((dirp)->dd_fd)

*** [scan.lo] Error code 1



>How-To-Repeat:
	
/usr/src/build.sh -O /var/shm/sparc64 -T /var/shm/tools.sparc64 -U -u -m sparc64 -j40 tools release iso-image
>Fix:
yes please.

>Unformatted: