NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/53476 CVS commit: [netbsd-8] src/external/bsd/cron/dist
The following reply was made to PR bin/53476; it has been noted by GNATS.
From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/53476 CVS commit: [netbsd-8] src/external/bsd/cron/dist
Date: Tue, 7 Aug 2018 13:24:59 +0000
Module Name: src
Committed By: martin
Date: Tue Aug 7 13:24:59 UTC 2018
Modified Files:
src/external/bsd/cron/dist [netbsd-8]: entry.c
Log Message:
Pull up following revision(s) (requested by kre in ticket #959):
external/bsd/cron/dist/entry.c: revision 1.9,1.10
Fix from Michael Kaufmann in PR bin/53476
Do modulus using unsigned arith, and then convert the result to
int, rather than converting the arc4random() result to int (which
might be negative) and performing a modulus on that (with a
potentially negative answer).
Add some more "crappy error detection" - the low value of
the range of random_with_range() must not be negative (or now
we are doing unsigned modulus we might generate a very big result).
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.7.8.1 src/external/bsd/cron/dist/entry.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index