lib/53505: multiple-evaluation issues in bitstring(3)

[paul%whooppee.com@localhost]

>Number:         53505
>Category:       lib
>Synopsis:       multiple-evaluation issues in bitstring(3)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 07 00:00:00 +0000 2018
>Originator:     Paul Goyette
>Release:        NetBSD 8.99.22
>Organization:
+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+
>Environment:
	
	
System: NetBSD speedy.whooppee.com 8.99.22 NetBSD 8.99.22 (SPEEDY 2018-07-25 07:42:52 UTC) #0: Wed Jul 25 13:38:00 UTC 2018 paul%speedy.whooppee.com@localhost:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
	
The operations described in bitstring(3) and implemented as macros in
/usr/include/bitstring.h suffer from possible problems with multiple
evaluations of the macro arguments, particularly if the bit number
argument includes a ++ or -- !
>How-To-Repeat:
Inspect the code.
	
>Fix:
It was suggested on tech-userlevel@ to replace susceptible macros with
static inline functions, similarly to what is done in sys/event.h for
EV_SET
	

>Unformatted: