Re: bin/53285: Build times tripled with make/job.c 1.193

["Simon J. Gerraty" <sjg%juniper.net@localhost>]

The following reply was made to PR bin/53285; it has been noted by GNATS.

From: "Simon J. Gerraty" <sjg%juniper.net@localhost>
To: 
Cc: <gnats-bugs%NetBSD.org@localhost>, <gnats-admin%NetBSD.org@localhost>,
        <netbsd-bugs%NetBSD.org@localhost>, Andreas Gustafsson <gson%gson.org@localhost>,
        <sjg%juniper.net@localhost>
Subject: Re: bin/53285: Build times tripled with make/job.c 1.193
Date: Sun, 13 May 2018 11:58:00 -0700

 Simon J. Gerraty <sjg%juniper.net@localhost> wrote:
 > Obviously need more coffee...
 
 But anyway, means the originally propsed change (below) should be ok
 which is what a lot of folk have been running for some time with no
 ill effect.
 
 I'm interested though to see if simply fixing the when job token pipe
 was polled also results in reduced sys overhead.
 
 Index: job.c
 ===================================================================
 RCS file: /cvsroot/src/usr.bin/make/job.c,v
 retrieving revision 1.194
 diff -u -p -r1.194 job.c
 --- job.c	13 May 2018 12:10:36 -0000	1.194
 +++ job.c	13 May 2018 18:52:38 -0000
 @@ -2950,7 +2950,6 @@ Job_TokenWithdraw(void)
  	}
  	if (DEBUG(JOB))
  	    fprintf(debug_file, "(%d) blocked for token\n", getpid());
 -	wantToken = 1;
  	return FALSE;
      }