Re: install/53220: sysinst dumps core with extended partitioning.

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR install/53220; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: install/53220: sysinst dumps core with extended partitioning.
Date: Tue, 1 May 2018 11:20:06 +0200

 On Tue, May 01, 2018 at 04:30:01AM +0000, Robert Elz wrote:
 >  which looks kind of OK, except there is no "grep" in the MFS miniroot
 >  so that is always going to fail (return false).
 
 OK, you are using the ram disk based installers, while I tested with the
 CD image.
 
 >  A much better solution would be to have a new sub-command for
 >  gpt like
 >  
 >  	gpt [-q] query dev
 
 I did a very lazy poor man's version of that.
 
 >  when "vnconfig" was renamed as "vndconfig" ages ago, and you
 >  have a recipe for potential disaster, when someone eventually
 >  decides that enough time has passed, and the old vnconfig
 >  link to vndconfig should simply be dropped (changing the 4
 >  occurrences of vnconfig into vndconfig should be easy!)
 
 I replaced the name.
 
 >  Of course, the same recipe for disaster (not potential) exists when
 >  there is no insalled vnconfig (or vndconfig) program at all - which is
 >  the case on the MFS mini-roon that's embedded in the INSTALL
 >  kernel.
 
 We have the "have_vnd" variable to note that.
 
 >  Fixing this would mean actually writing the function, which
 >  given the simplicity of the other similar functions does't look
 >  like it should be too hard, eg, this example...
 >  
 >  void
 >  remove_cgd_options() 
 >  {
 >          /* 
 >           * No CGD available, remove the following menu entries:
 >           */
 >          remove_menu_option(MENU_pmdiskentry, MSG_encrypt);
 >          remove_menu_option(MENU_pmpartentry, MSG_encrypt);
 >  }
 
 Indeed, but I'm not quite sure what menus exactly you want to remove
 in this case.
 
 Martin